Skip to contentSkip to conversation

proc: fix task_struct leak in proc_pid_fd_link_getattr()

PATCH Vasiliy Kulikov 1 participant 1 message Sep 2, 2011 Proc filesystem

lore
Share & tools
lore
#0 lore raw

In the patch "proc: fix races against execve() of /proc/PID/fd**" proc_pid_fd_link_getattr() leaked task_struct if ptrace check fails.

--

 fs/proc/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/proc/base.c +1 -1
index b65bd88..d44c701 100644
@@ -1681,9 +1681,9 @@ static int proc_pid_fd_link_getattr(struct vfsmount *mnt, struct dentry *dentry,
 
 	generic_fillattr(inode, stat);
 	unlock_trace(task);
-	put_task_struct(task);
 	rc = 0;
 out_task:
+	put_task_struct(task);
 	return rc;
 }
 
Signature · 1 line
Vasiliy