Janitor: Typo in stack debug code
PATCH 1/1 Janitor: Typo in stack debug code
In the debug routine check_stack_usage(), free stack space is counted in units of (unsigned long), not bytes. Make this clear when printing.
It seems easiest to just change the message, instead of multiplying by sizeof(unsigned long).
---
===================================================================
kernel/exit.c +1 -1
@@ -888,7 +888,7 @@ static void check_stack_usage(void)spin_lock (&low_water_lock);if (free < lowest_to_date) { -printk (KERN_WARNING "%s used greatest stack depth: %lu bytes " +printk (KERN_WARNING "%s used greatest stack depth: %lu words " "left\n" , current->comm, free); lowest_to_date = free;
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
2011/9/13 Linas Vepstas (Code Aurora) <[email protected]>:
Quoted 19 lines
In the debug routine
check_stack_usage(), free stack space is counted in units of (unsigned long), not bytes. Make this clear when printing.It seems easiest to just change the message, instead of multiplying by sizeof(unsigned long).
Signed-off-by Linas Vepstas <[email protected]>---
===================================================================
kernel/exit.c static void check_stack_usage(void) · line 894
Quoted 8 lines
kernel/exit.c +1
-1@@ -888,7 +888,7 @@ static void check_stack_usage(void) spin_lock(&low_water_lock); if (free < lowest_to_date) { - printk(KERN_WARNING "%s used greatest stack depth: %lu bytes " + printk(KERN_WARNING "%s used greatest stack depth: %lu words " "left\n", current->comm, free); lowest_to_date = free;
Thats not true, everything is fine.
dmesg | grep stack
[ 1.564907] kworker/u:0 used greatest stack depth: 5592 bytes left [ 2.467909] modprobe used greatest stack depth: 5576 bytes left [ 2.483228] exe used greatest stack depth: 5552 bytes left [ 2.489430] all_generic_ide used greatest stack depth: 5496 bytes left [ 2.524731] scsi_id used greatest stack depth: 5440 bytes left [ 2.643103] blkid used greatest stack depth: 4768 bytes left [ 4.232051] exe used greatest stack depth: 4320 bytes left [ 4.761443] stty used greatest stack depth: 3784 bytes left [ 6.011566] modprobe used greatest stack depth: 3664 bytes left [ 6.011681] modprobe used greatest stack depth: 3184 bytes left [ 339.890273] nroff used greatest stack depth: 3032 bytes left
Quoted 6 lines · Eric Dumazet
2011/9/13 Linas Vepstas (Code Aurora) <[email protected]>:
Quoted 3 lines
In the debug routine
check_stack_usage(), free stack space is counted in units of (unsigned long), not bytes. Make this clear when printing.Thats not true, everything is fine.
You are correct, I was wrong. Wow. Monday morning fuziness on a Tues. My apologies.
--linas
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.