Skip to contentSkip to conversation

FireWire fix

GIT PULL Stefan Richter 1 participant 1 message Sep 17, 2011 Firewire

lore
Share & tools
lore
#0 lore raw

Linus, please pull from the fixes branch at

    git://git.user.in-berlin.de/s5r6/linux1394.git fixes

to receive a hardware quirks flag. Thanks.

Ming Lei (1):
firewire: ohci: add no MSI quirk for O2Micro controller

 drivers/firewire/ohci.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

commit f39aa30d7741f40ad964341e9243dbbd7f8ff057

Author: Ming Lei <[email protected]>
Date:   Wed Aug 31 10:45:46 2011 +0800

firewire: ohci: add no MSI quirk for O2Micro controller

This fixes https://bugs.launchpad.net/ubuntu/+source/linux/+bug/801719 .

An O2Micro PCI Express FireWire controller,
"FireWire (IEEE 1394) [0c00]: O2 Micro, Inc. Device [1217:11f7] (rev 05)" which is a combination device together with an SDHCI controller and some sort of storage controller, misses SBP-2 status writes from an attached FireWire HDD. This problem goes away if MSI is disabled for this FireWire controller.

The device reportedly does not require QUIRK_CYCLE_TIMER.

drivers/firewire/ohci.c +3 -0
index 57cd3a4..fd7170a 100644
@@ -290,6 +290,9 @@ static const struct {
 	{PCI_VENDOR_ID_NEC, PCI_ANY_ID, PCI_ANY_ID,
 		QUIRK_CYCLE_TIMER},
 
+	{PCI_VENDOR_ID_O2, PCI_ANY_ID, PCI_ANY_ID,
+		QUIRK_NO_MSI},
+
 	{PCI_VENDOR_ID_RICOH, PCI_ANY_ID, PCI_ANY_ID,
 		QUIRK_CYCLE_TIMER},
 
Signature · 3 lines
Stefan Richter
-=====-==-== =--= =---=
http://arcgraph.de/sr/