Skip to contentSkip to conversation

(xen) stable/for-jens-3.2 - blkback and blkfront patches for 3.2

GIT PULL Konrad Rzeszutek Wilk 3 participants 5 messages Sep 21, 2011 – Sep 25, 2011 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hey Jens,

Please pull the following git tree in your 3.2 drivers tree:

git pull git://oss.oracle.com/git/kwilk/xen.git stable/for-jens-3.2

which has an exciting new feature - the discard ('feature-discard') aka TRIM/UNMAP. Now they can be passed from the guest to the backend.

There is also a tiny cleanup patch.

 drivers/block/xen-blkback/blkback.c |   86 +++++++++++++++++++++++-----
 drivers/block/xen-blkback/common.h  |   95 ++++++++++++++++++++++++------
 drivers/block/xen-blkback/xenbus.c  |   62 +++++++++++++++++++-
 drivers/block/xen-blkfront.c        |  109 +++++++++++++++++++++++++++-------
 include/xen/interface/io/blkif.h    |   36 ++++++++++++
 5 files changed, 331 insertions(+), 57 deletions(-)

Joe Jin (1):
xen-blkback: fixed indentation and comments

Li Dongyang (4):
xen-blkfront: add BLKIF_OP_DISCARD and discard request struct
xen-blkback: Implement discard requests ('feature-discard')
xen-blkfront: Handle discard requests.
xen-blkfront: fix a deadlock while handling discard response

#1 lore raw
Quoted 8 lines · Konrad Rzeszutek Wilk

Hey Jens,

Please pull the following git tree in your 3.2 drivers tree:

git pull git://oss.oracle.com/git/kwilk/xen.git stable/for-jens-3.2

which has an exciting new feature - the discard ('feature-discard') aka TRIM/UNMAP. Now they can be passed from the guest to the backend.

What is the design of them? Do you provide the 'discard zeroes data' flag (mandatory for any kind of relible operation) and 'discard granularity / alignment' tunables (very useful)?

#2 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Konrad Rzeszutek Wilk

Hey Jens,

Please pull the following git tree in your 3.2 drivers tree:

Quoted 7 lines
Quoted 4 lines

git pull git://oss.oracle.com/git/kwilk/xen.git stable/for-jens-3.2

which has an exciting new feature - the discard ('feature-discard') aka TRIM/UNMAP. Now they can be passed from the guest to the backend.

What is the design of them? Do you provide the 'discard zeroes data' flag (mandatory for any kind of relible operation) and 'discard

Hmm, not sure what that is. Is that REQ_SECURE, err BLKDEV_DISCARD_SECURE? If so then not in this patchset - but it does not seem like it would dificult to add that in? Li, what do you think?

Quoted 1 line

granularity / alignment' tunables (very useful)?

The discard granularity/alignment are certainly there. But they are just one way (backend tells the guest what they are). Should they be more tunable (frontend tells the backend what the values ought to be?)

Li, did I miss anything in my response?

#4 lore raw
In reply to a message not in the archive
Quoted 20 lines · Li Dongyang
Quoted 8 lines · Konrad Rzeszutek Wilk
Quoted 7 lines · Christoph Hellwig
Quoted 6 lines · Konrad Rzeszutek Wilk

Hey Jens,

Please pull the following git tree in your 3.2 drivers tree:

git pull git://oss.oracle.com/git/kwilk/xen.git stable/for-jens-3.2

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

which has an exciting new feature - the discard ('feature-discard') aka TRIM/UNMAP. Now they can be passed from the guest to the backend.

What is the design of them? Do you provide the 'discard zeroes data' flag (mandatory for any kind of relible operation) and 'discard

Hmm, not sure what that is. Is that REQ_SECURE, err BLKDEV_DISCARD_SECURE? If so then not in this patchset - but it does not seem like it would

dificult

Quoted 1 line

to add that in? Li, what do you think?

Quoted 8 lines

We deal the discard with 2 ways in the backend depend on what the guest is using:
punch the hole on the image, to save some disk usage,
or redirect the discard request to phy device.
for the hole punching case, we are already DISCARD_SECURE,
for the phy dev case, we could add the flag and pass it from blkfront to blkback, and yes
That's not difficult, could be added later.

Li, could you implement it please - on top of the 'stable/for-jens-3.2' patch queue ? If it would not be too much trouble of course.

Quoted 12 lines
Quoted 7 lines
Quoted 2 lines

granularity / alignment' tunables (very useful)?

The discard granularity/alignment are certainly there. But they are just one way (backend tells the guest what they are). Should they be more tunable (frontend tells the backend what the values ought to be?)

Yes, plz tell more about tunable granularity and alignment, and we can add that later,
Thanks a lot

Quoted 2 lines

Li, did I miss anything in my response?

#6 lore raw
In reply to a message not in the archive

seems my mail did not reach the mailing list?

Quoted 58 lines · Li Dongyang
Quoted 33 lines · Konrad Rzeszutek Wilk
Quoted 22 lines · Li Dongyang
Quoted 12 lines · Konrad Rzeszutek Wilk
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Konrad Rzeszutek Wilk

Hey Jens,

Please pull the following git tree in your 3.2 drivers tree:

 git pull git://oss.oracle.com/git/kwilk/xen.git stable/for-jens-3.2

which has an exciting new feature - the discard ('feature-discard') aka TRIM/UNMAP. Now they can be passed from the guest to the backend.

Quoted 6 lines
Quoted 2 lines

What is the design of them?  Do you provide the 'discard zeroes data' flag (mandatory for any kind of relible operation) and 'discard

Hmm, not sure what that is. Is that REQ_SECURE, err BLKDEV_DISCARD_SECURE?
If so then not in this patchset - but it does not seem like it would

dificult

Quoted 1 line

to add that in? Li, what do you think?

Quoted 9 lines

We deal the discard with 2 ways in the backend depend on what the guest is
using:
punch the hole on the image, to save some disk usage,
or redirect the discard request to phy device.
for the hole punching case, we are already DISCARD_SECURE, for the phy dev case, we could add the flag and pass it from blkfront to blkback, and yes
That's not difficult, could be added later.

Quoted 3 lines

Li, could you implement it please  - on top of the 'stable/for-jens-3.2' patch queue ?
If it would not be too much trouble of course.

Yeah I'd like to, but am on a vacation to Australia, nothing with me except an iPad,
and I'll be back on 7th next month, so I gonna sent a patch after that, Thanks.

Quoted 16 lines
Quoted 15 lines
Quoted 9 lines
Quoted 3 lines

granularity / alignment' tunables (very useful)?

The discard granularity/alignment are certainly there. But they are just
one way (backend tells the guest what they are). Should they be more tunable (frontend tells the backend what the values ought to be?)

Yes, plz tell more about tunable granularity and alignment, and we can add
that later,
Thanks a lot

Quoted 2 lines

Li, did I miss anything in my response?