Staging: vt6655-6: potential info leak in private_ioctl()

PATCH New Dan Carpenter 1 participant 1 message Sep 23, 2011

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2011-09-23 06:23 UTC #0 lore raw

PATCH 1/1 Staging: vt6655-6: potential info leak in private_ioctl()

Smatch has a new check for Rosenberg type information leaks where structs are copied to the user with uninitialized stack data in them.

In this path, the .uLinkRate member doesn't get initialized so I've set it to zero.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/vt6655/ioctl.c +1 -0

index 8cf88c3..43964a5 100644
@@ -296,6 +296,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) {
         }
         else {
             sLinkStatus.bLink = false;
+	    sLinkStatus.uLinkRate = 0;
         }
         if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) {
 			result = -EFAULT;

drivers/staging/vt6656/ioctl.c +1 -0

index cfe9c95..1cb9a7d 100644
@@ -291,6 +291,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) {
         }
         else {
             sLinkStatus.bLink = FALSE;
+	    sLinkStatus.uLinkRate = 0;
         }
         if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) {
 			result = -EFAULT;