exofs/super.c: local functions should be static
PATCH 1/1 exofs/super.c: local functions should be static
This quiets the following sparse noise:
warning: symbol 'exofs_sync_fs' was not declared. Should it be static?
warning: symbol 'exofs_free_sbi' was not declared. Should it be static?
warning: symbol 'exofs_get_parent' was not declared. Should it be static?
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Boaz Harrosh <[email protected]>
Cc Benny Halevy <[email protected]>
---
fs/exofs/super.c +3 -3
@@ -356,7 +356,7 @@ static const struct export_operations exofs_export_ops;/* * Write the superblock to the OSD */ -int exofs_sync_fs (struct super_block *sb,int wait) +static int exofs_sync_fs (struct super_block *sb,int wait) {struct exofs_sb_info *sbi;struct exofs_fscb *fscb;
@@ -430,7 +430,7 @@ static void _exofs_print_device(const char *msg, const char *dev_path, msg, dev_path ?: "", odi->osdname, _LLU(pid)); } -void exofs_free_sbi (struct exofs_sb_info *sbi) +static void exofs_free_sbi (struct exofs_sb_info *sbi) {while (sbi->comps.numdevs) {int i = --sbi->comps.numdevs;
@@ -969,7 +969,7 @@ static const struct super_operations exofs_sops = {* EXPORT OPERATIONS *****************************************************************************/ -struct dentry *exofs_get_parent (struct dentry *child) +static struct dentry *exofs_get_parent (struct dentry *child) {unsigned long ino =exofs_parent_ino (child);
Quoted 10 lines · H Hartley Sweeten
This quiets the following sparse noise:
warning: symbol '
exofs_sync_fs' was not declared. Should it be static?
warning: symbol 'exofs_free_sbi' was not declared. Should it be static?
warning: symbol 'exofs_get_parent' was not declared. Should it be static?Signed-off-by H Hartley Sweeten <[email protected]>Cc Boaz Harrosh <[email protected]>Cc Benny Halevy <[email protected]>
Both patches are in linux-next for the next merge window
Thanks Hartley
Boaz
Quoted 33 lines
---
fs/exofs/super.c +3
-3@@ -356,7 +356,7 @@ static const struct export_operations exofs_export_ops;/* * Write the superblock to the OSD */ -int exofs_sync_fs (struct super_block *sb,int wait) +static int exofs_sync_fs (struct super_block *sb,int wait) {struct exofs_sb_info *sbi;struct exofs_fscb *fscb;@@ -430,7 +430,7 @@ static void _exofs_print_device(const char *msg, const char *dev_path, msg, dev_path ?: "", odi->osdname, _LLU(pid)); } -void exofs_free_sbi (struct exofs_sb_info *sbi) +static void exofs_free_sbi (struct exofs_sb_info *sbi) {while (sbi->comps.numdevs) {int i = --sbi->comps.numdevs;@@ -969,7 +969,7 @@ static const struct super_operations exofs_sops = {* EXPORT OPERATIONS *****************************************************************************/ -struct dentry *exofs_get_parent (struct dentry *child) +static struct dentry *exofs_get_parent (struct dentry *child) {unsigned long ino =exofs_parent_ino (child);