gfs2/inode.c: local functions should be static
PATCH 1/1 gfs2/inode.c: local functions should be static
Quiets the sparse noise:
warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
---
fs/gfs2/inode.c +1 -1
@@ -624,7 +624,7 @@ fail:return error; } -int gfs2_initxattrs (struct inode *inode,const struct xattr *xattr_array, +static int gfs2_initxattrs (struct inode *inode,const struct xattr *xattr_array,void *fs_info) {const struct xattr *xattr;
Hi,
Quoted 4 lines · H Hartley Sweeten
Quiets the sparse noise:
warning: symbol '
gfs2_initxattrs' was not declared. Should it be static?
Where did you find this function? It is not in the upstream gfs2 code...
Steve.
Quoted 18 lines
Signed-off-by H Hartley Sweeten <[email protected]>Cc Steven Whitehouse <[email protected]>---
fs/gfs2/inode.c +1
-1@@ -624,7 +624,7 @@ fail:return error; } -int gfs2_initxattrs (struct inode *inode,const struct xattr *xattr_array, +static int gfs2_initxattrs (struct inode *inode,const struct xattr *xattr_array,void *fs_info) {const struct xattr *xattr;
Quoted 8 lines · Steven Whitehouse
Hi,
Quoted 4 lines · H Hartley Sweeten
Quiets the sparse noise:
warning: symbol '
gfs2_initxattrs' was not declared. Should it be static?Where did you find this function? It is not in the upstream gfs2 code...
linux-next next-20110831
This was the last update I pulled before git.kernel.org went down.
It looks like it was added by:
commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
Author: Mimi Zohar <[email protected]> Date: Mon Jun 6 15:29:25 2011 -0400
security: new security_inode_init_security API adds function callback
If this has been removed since then please ignore.
Thanks,
Hartley ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�
Hi,
Quoted 20 lines · H Hartley Sweeten
Quoted 8 lines · Steven Whitehouse
Hi,
Quoted 4 lines · H Hartley Sweeten
Quiets the sparse noise:
warning: symbol '
gfs2_initxattrs' was not declared. Should it be static?Where did you find this function? It is not in the upstream gfs2 code...
linux-next next-20110831
This was the last update I pulled before git.kernel.org went down.
It looks like it was added by:
commit
9d8f13ba3f4833219e50767b022b82cd0da930ebAuthor: Mimi Zohar <[email protected]> Date: Mon Jun 6 15:29:25 2011 -0400
Quoted 6 lines
security: new
security_inode_init_securityAPI adds function callbackIf this has been removed since then please ignore.
Thanks,
Hartley
I think it is a question of it not yet being added. You should send the patch to Mimi so it is included in the correct patch series. Otherwise remind me when the code is applies against is merged and I'll look at it again then,
Steve.