Skip to contentSkip to conversation

Staging: iio/light/tsl2563: unlock on an error path

PATCH In review Dan Carpenter 2 participants 2 messages Oct 6, 2011

Subsystems (4)
Staging Kernel janitors IIO Staging - industrial io
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 Staging: iio/light/tsl2563: unlock on an error path

We need to unlock here before returning.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/iio/light/tsl2563.c +2 -1
index 3707772..8977f58 100644
@@ -518,7 +518,8 @@ static int tsl2563_read_raw(struct iio_dev *indio_dev,
 		ret = IIO_VAL_INT;
 		break;
 	default:
-		return -EINVAL;
+		ret = -EINVAL;
+		goto error_ret;
 	}
 
 error_ret:
Acked-by on v1 1/2
#1 lore raw
Quoted 1 line · Dan Carpenter

We need to unlock here before returning.

Thanks

Quoted 2 lines
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Jonathan Cameron <[email protected]>
Quoted 16 lines
drivers/staging/iio/light/tsl2563.c +2 -1
index 3707772..8977f58 100644
@@ -518,7 +518,8 @@ static int tsl2563_read_raw(struct iio_dev *indio_dev,
 		ret = IIO_VAL_INT;
 		break;
 	default:
-		return -EINVAL;
+		ret = -EINVAL;
+		goto error_ret;
 	}
 
 error_ret: