Skip to contentSkip to conversation

wm8400-core: select REGMAP_I2C in kconfig

PATCH Dave Jones 2 participants 4 messages Oct 25, 2011 – Oct 26, 2011 Multifunction devices (MFD)

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

wm8400-core.c is using the regmap I2C API, so needs to select it.

ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!

Signed-off-by Dave Jones <[email protected]>
drivers/mfd/Kconfig +1 -0
index a67adcb..67a6126 100644
@@ -389,6 +389,7 @@ config MFD_MAX8998
 config MFD_WM8400
 	tristate "Support Wolfson Microelectronics WM8400"
 	select MFD_CORE
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Support for the Wolfson Microelecronics WM8400 PMIC and audio
#1 lore raw
Quoted 8 lines · Dave Jones

wm8400-core.c is using the regmap I2C API, so needs to select it.

ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!

Which kernel version are you looking at? This is correct in my current kernel - fixed in commit 2b247d06. Though I suspect that's waiting to trickle down into Linus' tree still.

author
#2 lore raw
Quoted 10 lines · Mark Brown
Quoted 8 lines · Dave Jones

wm8400-core.c is using the regmap I2C API, so needs to select it.

ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!

Quoted 3 lines

Which kernel version are you looking at? This is correct in my current kernel - fixed in commit 2b247d06. Though I suspect that's waiting to trickle down into Linus' tree still.

That was yesterdays git (don't have the hash handy). Today, as of efb8d21b2c6db3497655cc6a033ae8a9883e4063 I can't reproduce it, though I don't know why, as that file is definitly still using regmap, and there's no select, and it's not in my .config.

Dave

#3 lore raw
Quoted 4 lines · Dave Jones

That was yesterdays git (don't have the hash handy). Today, as of efb8d21b2c6db3497655cc6a033ae8a9883e4063 I can't reproduce it, though I don't know why, as that file is definitly still using regmap, and there's no select, and it's not in my .config.

I guess it's not terribly important so long as the patch I mentioned that's in Samuel's tree makes it in during the merge window.