drm/i915: fix if statement (bogus semi-colon)
Subsystems (2)
PATCH 1/1 drm/i915: fix if statement (bogus semi-colon)
The semi-colon is a typo here and it makes the if statement unconditional.
Signed-off-by Dan Carpenter <[email protected]>
drivers/char/agp/intel-gtt.c +1 -1
@@ -1236,7 +1236,7 @@ static int i9xx_setup(void) intel_private.gtt_bus_addr = reg_addr + gtt_offset; } -if (needs_idle_maps ()); +if (needs_idle_maps ()) intel_private.base.do_idle_maps =1 ;intel_i9xx_setup_flush ();
drivers/char/agp/intel-gtt.c static int i9xx_setup(void) · line 1239
Quoted 2 lines · Dan Carpenter
drivers/char/agp/intel-gtt.c +1
-1-if (needs_idle_maps ()); +if (needs_idle_maps ())
how embarrassing is that?
Signature · 1 line
[email protected]
Quoted 6 lines · Keith Packard
drivers/char/agp/intel-gtt.c static int i9xx_setup(void) · line 1239
Quoted 2 lines · Dan Carpenter
drivers/char/agp/intel-gtt.c +1
-1-if (needs_idle_maps ()); +if (needs_idle_maps ())how embarrassing is that?
Actually it served an ulterior purpose and by exercising the workaround showed us that it contained a more subtle bug. I believe therefore Ben did it deliberately ;-)
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre