drm/radeon/benchmark: signedness bug in radeon_benchmark_move()

PATCH New Dan Carpenter 1 participant 1 message Oct 29, 2011

Subsystems (3)

DRM drivers Kernel janitors Radeon and amdgpu DRM drivers

lore

Share & tools

lore

Dan Carpenter

author

2011-10-29 07:21 UTC #0 lore raw

PATCH 1/1 drm/radeon/benchmark: signedness bug in radeon_benchmark_move()

radeon_benchmark_do_move() returns an int so "time" should be int too. Making it unsigned breaks the error handling.

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpu/drm/radeon/radeon_benchmark.c +1 -1

index 5cafc90..17e1a9b 100644
@@ -98,7 +98,7 @@ static void radeon_benchmark_move(struct radeon_device *rdev, unsigned size,
 	struct radeon_bo *sobj = NULL;
 	uint64_t saddr, daddr;
 	int r, n;
-	unsigned int time;
+	int time;
 
 	n = RADEON_BENCHMARK_ITERATIONS;
 	r = radeon_bo_create(rdev, size, PAGE_SIZE, true, sdomain, &sobj);