Skip to contentSkip to conversation

mmc: omap_hsmmc: Fix build for hsmmc

PATCH In review Tony Lindgren 2 participants 3 messages Nov 2, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: omap_hsmmc: Fix build for hsmmc

Commit a3c76eb9d4a1e68a69dd880cf0bcb8a52418b993 (mmc: replace printk with appropriate display macro) does not compile:

drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
drivers/mmc/host/omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function) drivers/mmc/host/omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once drivers/mmc/host/omap_hsmmc.c:1273: error: for each function it appears in.) drivers/mmc/host/omap_hsmmc.c:1273: error: expected ';' before string constant drivers/mmc/host/omap_hsmmc.c:1275: error: expected statement before ')' token distcc[15197] ERROR: compile drivers/mmc/host/omap_hsmmc.c on localhost failed

drivers/mmc/host/omap_hsmmc.c +1 -1
@@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
 		}
 	} else {
 		if (!host->protect_card) {
-			pr_info"%s: cover is open, "
+			pr_info("%s: cover is open, "
 					 "card is now inaccessible\n",
 					 mmc_hostname(host->mmc));
 			host->protect_card = 1;
#1 lore raw

Hello Tony, hello Chris,https://mail.google.com/mail/?shva=1#label/linux-omap/133653efb30ae047

isn't this already fixed?

http://marc.info/?l=linux-omap&m=131991921316862&w=2

[PATCH] omap_hsmmc: fix missing parenthesis in pr_info

Thomas

Quoted 28 lines · Tony Lindgren

Commit a3c76eb9d4a1e68a69dd880cf0bcb8a52418b993 (mmc: replace printk with appropriate display macro) does not compile:

drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
drivers/mmc/host/omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function) drivers/mmc/host/omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once drivers/mmc/host/omap_hsmmc.c:1273: error: for each function it appears in.) drivers/mmc/host/omap_hsmmc.c:1273: error: expected ';' before string constant drivers/mmc/host/omap_hsmmc.c:1275: error: expected statement before ')' token distcc[15197] ERROR: compile drivers/mmc/host/omap_hsmmc.c on localhost failed

drivers/mmc/host/omap_hsmmc.c +1 -1
@@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
                }
        } else {
                if (!host->protect_card) {
-                       pr_info"%s: cover is open, "
+                       pr_info("%s: cover is open, "
                                         "card is now inaccessible\n",
                                         mmc_hostname(host->mmc));
                        host->protect_card = 1;