Skip to contentSkip to conversation

ixgbe: compilation failed if CONFIG_PCI_IOV isn't set

DISCUSSION Alexander Kolesen 4 participants 5 messages Nov 6, 2011 – Nov 7, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello.
I've tried to build vanilla kernel (HEAD: 5c8a0fbb) and got the error:

CC [M] drivers/net/ethernet/intel/ixgbe/ixgbe_main.o
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_set_interrupt_capability':
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:4724:3: error: implicit declaration of function 'ixgbe_disable_sriov' drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_remove':
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:7773:3: error: implicit declaration of function 'ixgbe_check_vf_assignment' make[5]: *** [drivers/net/ethernet/intel/ixgbe/ixgbe_main.o] Error 1
make[4]: *** [drivers/net/ethernet/intel/ixgbe] Error 2
make[3]: *** [drivers/net/ethernet/intel] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Looks like the commit 9487dc84 breaks it when the CONFIG_PCI_IOV switched off.

#1 lore raw
Quoted 15 lines · Alexander Kolesen

Hello.
I've tried to build vanilla kernel (HEAD: 5c8a0fbb) and got the error:

CC [M] drivers/net/ethernet/intel/ixgbe/ixgbe_main.o
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_set_interrupt_capability':
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:4724:3: error: implicit declaration of function 'ixgbe_disable_sriov' drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_remove':
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:7773:3: error: implicit declaration of function 'ixgbe_check_vf_assignment' make[5]: *** [drivers/net/ethernet/intel/ixgbe/ixgbe_main.o] Error 1
make[4]: *** [drivers/net/ethernet/intel/ixgbe] Error 2
make[3]: *** [drivers/net/ethernet/intel] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Quoted 2 lines

Looks like the commit 9487dc84 breaks it when the CONFIG_PCI_IOV switched off.

Was with the latest kernel from David Miller's net.gt tree? I just ask because I just pushed a patch (a couple of days ago) to resolve compilation errors when CONFIG_PCI_IOV is not enabled by Greg Rose.

#2 lore raw
Quoted 3 lines · Jeff Kirsher

Was with the latest kernel from David Miller's net.gt tree?  I just ask because I just pushed a patch (a couple of days ago) to resolve compilation errors when CONFIG_PCI_IOV is not enabled by Greg Rose.

In my case it was with Linus tree from github

Or.

#3 lore raw
Quoted 9 lines
Quoted 3 lines · Jeff Kirsher

Was with the latest kernel from David Miller's net.gt tree?  I just ask because I just pushed a patch (a couple of days ago) to resolve compilation errors when CONFIG_PCI_IOV is not enabled by Greg Rose.

In my case it was with Linus tree from github

Or.

It was with Linus tree, but David Miller's net.gt alsa has this issue.

#4 lore raw
Quoted 10 lines

-----Original Message-----
From: Alexander Kolesen [mailto:[email protected]]
Sent: Monday, November 07, 2011 4:47 AM
To: Or Gerlitz
Cc: Kirsher, Jeffrey T; [email protected]; Rose, Gregory V; Li, Sibai
Subject: Re: ixgbe: compilation failed if CONFIG_PCI_IOV isn't set

Quoted 3 lines
Quoted 1 line · Jeff Kirsher

Was with the latest kernel from David Miller's net.gt tree?  I just

Quoted 8 lines

ask

Quoted 6 lines
Quoted 2 lines

because I just pushed a patch (a couple of days ago) to resolve compilation errors when CONFIG_PCI_IOV is not enabled by Greg Rose.

In my case it was with Linus tree from github

Or.

It was with Linus tree, but David Miller's net.gt alsa has this issue.

Yeah, I'll have it fixed soon. My apologies.

- Greg