tty_ldisc: remove unnecessary negative return check for wait_event_timeout
PATCH 1/1 tty_ldisc: remove unnecessary negative return check for wait_event_timeout
wait_event_timeout always return value >= 0
remove the unnecessary ret < 0 check
Signed-off-by Dave Young <[email protected]>
--- drivers/tty/tty_ldisc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/tty/tty_ldisc.c +0 -2
@@ -556,8 +556,6 @@ static int tty_ldisc_wait_idle(struct ttint ret; ret =wait_event_timeout (tty_ldisc_idle,atomic_read (&tty->ldisc->users) ==1 ,5 *HZ ); -if (ret <0 ) -return ret;return ret >0 ?0 : -EBUSY ; }
Quoted 4 lines · Dave Young
wait_event_timeoutalways return value >= 0
remove the unnecessary ret < 0 checkSigned-off-by Dave Young <[email protected]>
Acked-by Jiri Slaby <[email protected]>
This is a hangover from times when there was _interruptible.
Quoted 15 lines
--- drivers/tty/tty_ldisc.c | 2 -- 1 file changed, 2 deletions(-)drivers/tty/tty_ldisc.c +0
-2@@ -556,8 +556,6 @@ static int tty_ldisc_wait_idle(struct ttint ret; ret =wait_event_timeout (tty_ldisc_idle,atomic_read (&tty->ldisc->users) ==1 ,5 *HZ ); -if (ret <0 ) -return ret;return ret >0 ?0 : -EBUSY ; }
Signature · 2 lines
js suse labs