kdump: kill redundant code
Subsystems (3)
PATCH 1/1 kdump: kill redundant code
in while loop below, hole_end > crashk_res.end is impossible:
while (hole_end <= crashk_res.end) {
[snip]
}Killing the check code here
Signed-off-by Dave Young <[email protected]>
--- kernel/kexec.c | 2 -- 1 file changed, 2 deletions(-)
kernel/kexec.c +0 -2
@@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_cif (hole_end >KEXEC_CRASH_CONTROL_MEMORY_LIMIT )break ; -if (hole_end > crashk_res.end) -break ;/* See if I overlap any of the segments */ for (i =0 ; i < image->nr_segments; i++) {unsigned long mstart, mend;
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 7 lines · Dave Young
in while loop below,
hole_end> crashk_res.end is impossible:while (hole_end <= crashk_res.end) { [snip] }Killing the check code here
Signed-off-by Dave Young <[email protected]>
Makes sense.
Acked-by Vivek Goyal <[email protected]>
Vivek
Quoted 7 lines
--- kernel/kexec.c | 2 -- 1 file changed, 2 deletions(-)
kernel/kexec.c static struct page *kimage_alloc_crash_c · line 505
Quoted 8 lines
kernel/kexec.c +0
-2@@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_cif (hole_end >KEXEC_CRASH_CONTROL_MEMORY_LIMIT )break ; -if (hole_end > crashk_res.end) -break ;/* See if I overlap any of the segments */ for (i =0 ; i < image->nr_segments; i++) {unsigned long mstart, mend;
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Simon Horman
Acked-byQuoted 7 lines · Vivek Goyal
Quoted 6 lines · Dave Young
in while loop below,
hole_end> crashk_res.end is impossible:while (hole_end <= crashk_res.end) { [snip] }Killing the check code here
Quoted 5 lines
Quoted 1 line
Signed-off-by Dave Young <[email protected]>Makes sense.
Acked-by Vivek Goyal <[email protected]>
Indeed it does. I wonder if this was always so redundant.
Acked-by Simon Horman <[email protected]>