Skip to contentSkip to conversation

mmc: ushc: fix an endianness conversion in ushc_request()

PATCH New Dan Carpenter 1 participant 1 message Nov 20, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: ushc: fix an endianness conversion in ushc_request()

The ->cmd_idx field is 8 bits, not 16 so the call to cpu_to_le16() will probably set cmd_idx to zero here on big endian systems.

---
This is a static checker bug. Untested.

drivers/mmc/host/ushc.c +1 -1
index f08f944..8b7367a 100644
@@ -278,7 +278,7 @@ static void ushc_request(struct mmc_host *mmc, struct mmc_request *req)
 	ushc->current_req = req;
 
 	/* Start cmd with CBW. */
-	ushc->cbw->cmd_idx = cpu_to_le16(req->cmd->opcode);
+	ushc->cbw->cmd_idx = req->cmd->opcode;
 	if (req->data)
 		ushc->cbw->block_size = cpu_to_le16(req->data->blksz);
 	else