Skip to contentSkip to conversation

debugfs: remove unneeded cast in debugfs_print_regs32()

PATCH New Dan Carpenter 1 participant 1 message Nov 24, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 debugfs: remove unneeded cast in debugfs_print_regs32()

The cast here causes a Sparse warning:
fs/debugfs/file.c:561:42: warning: cast removes address space of expression fs/debugfs/file.c:561:42: warning: incorrect type in argument 1 (different address spaces)
fs/debugfs/file.c:561:42: expected void const volatile [noderef] <asn:2>*addr
fs/debugfs/file.c:561:42: got void *<noident>

It's redundant to cast it to a (void *) anyway when it is already a (void __iomem *).

fs/debugfs/file.c +1 -1
index e0a3a59..989f07f 100644
@@ -558,7 +558,7 @@ int debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
 		if (prefix)
 			ret += seq_printf(s, "%s", prefix);
 		ret += seq_printf(s, "%s = 0x%08x\n", regs->name,
-				  readl((void *)(base + regs->offset)));
+				  readl(base + regs->offset));
 	}
 	return ret;
 }