Skip to contentSkip to conversation

support for antenna configuration profiles

PATCH New Daniel Golle 2 participants 2 messages Nov 28, 2011

lore
Share & tools
lore
#0 lore raw

cover support for antenna configuration profiles

Hi!
It took me a while to get this into a nice shape and make the code less hackish. Thank you for all the helpful feedback on PATCH v0 and the RFC!
I'm looking forward to your comments and highly appreciate any further advise.

Changes since my previous patch:
* restructured nl80211 stuff, putting the whole thing into a NLA_NESTED makes the parser happy.
* store selection state in the driver instead of overwriting the value in the AntCtrlCommon field.
* expose selected switch_com_value in eeprom_4k.
* moved stuff in ath9k to where it belongs (afaik)
* lots of cosmetics

I got my patched-up version of iw and works like a charm with the ALL0258N now:

root at OpenWrt:/# iw list
Wiphy phy0:
Band 1:
...
Device supports antenna configuration profiles.
(*) 0 horiz (horizontal TX, vertical RX)
( ) 1 vert (vertical TX, horizontal RX)
...

root at OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump 0x009964 0x00000000
root at OpenWrt:/# iw phy phy0 interface add wlan0 type station root at OpenWrt:/# ifconfig wlan0 up
root at OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump 0x009964 0x09a00210
root at OpenWrt:/# ifconfig wlan0 down
root at OpenWrt:/# iw set extant 1
root at OpenWrt:/# iw list
Wiphy phy0
Band 1:
...
Device supports antenna configuration profiles.
( ) 0 horiz (horizontal TX, vertical RX)
(*) 1 vert (vertical TX, horizontal RX)
...

root at OpenWrt:/# ifconfig wlan0 up
root at OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump 0x009964 0x0a900120

Here the patch for iw. I'm planing to partially reimplement that in libiwinfo for OpenWrt's LuCI.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20111128/25e7ac58/attachment.pgp

#1 lore raw

cover support for antenna configuration profiles

Hi Daniel,

we will get more review comments and more people to look when we send patches to
linux wireless mailing list. especially mac/cfg/nl 80211 changes

Quoted 56 lines · Daniel Golle

Hi!
It took me a while to get this into a nice shape and make the code less hackish. Thank you for all the helpful feedback on PATCH v0 and the RFC!
I'm looking forward to your comments and highly appreciate any further advise.

Changes since my previous patch:
?* restructured nl80211 stuff, putting the whole thing into a NLA_NESTED makes ? the parser happy.
?* store selection state in the driver instead of overwriting the value in the ? AntCtrlCommon field.
?* expose selected switch_com_value in eeprom_4k.
?* moved stuff in ath9k to where it belongs (afaik)
?* lots of cosmetics

I got my patched-up version of iw and works like a charm with the ALL0258N now:

root at OpenWrt:/# iw list
Wiphy phy0:
? ? ? ?Band 1:
? ? ? ?...
? ? ? ?Device supports antenna configuration profiles. ? ? ? ? ? ? ? ? (*) 0 ?horiz ? (horizontal TX, vertical RX) ? ? ? ? ? ? ? ? ( ) 1 ?vert ? ?(vertical TX, horizontal RX) ? ? ? ?...

root at OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump 0x009964 0x00000000
root at OpenWrt:/# iw phy phy0 interface add wlan0 type station root at OpenWrt:/# ifconfig wlan0 up
root at OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump 0x009964 0x09a00210
root at OpenWrt:/# ifconfig wlan0 down
root at OpenWrt:/# iw set extant 1
root at OpenWrt:/# iw list
Wiphy phy0
? ? ? ?Band 1:
? ? ? ?...
? ? ? ?Device supports antenna configuration profiles.
? ? ? ? ? ? ? ? ( ) 0 ?horiz ? (horizontal TX, vertical RX)
? ? ? ? ? ? ? ? (*) 1 ?vert ? ?(vertical TX, horizontal RX)
? ? ? ?...

root at OpenWrt:/# ifconfig wlan0 up
root at OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump 0x009964 0x0a900120

Here the patch for iw. I'm planing to partially reimplement that in libiwinfo for OpenWrt's LuCI.

_______________________________________________
ath9k-devel mailing list
ath9k-devel at lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel

Signature · 1 line
shafi