Skip to contentSkip to conversation

ipc/mqueue: lock() => unlock() typo

PATCH In review Dan Carpenter 2 participants 2 messages Nov 30, 2011 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipc/mqueue: lock() => unlock() typo

There was a double lock typo introduced in b085f4bd6b21 "user namespace:
make signal.c respect user namespaces"

---
I think this patch is only needed in the -mm tree.

ipc/mqueue.c +1 -1
index 691cfee..c246c83 100644
@@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
 						ns_of_pid(info->notify_owner));
 			sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
 						current_cred(), current_uid());
-			rcu_read_lock();
+			rcu_read_unlock();
 
 			kill_pid_info(info->notify.sigev_signo,
 				      &sig_i, info->notify_owner);
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

There was a double lock typo introduced in b085f4bd6b21 "user namespace:
make signal.c respect user namespaces"

Jinkeys!

thanks very much, Dan.
-serge

Quoted 16 lines

---
I think this patch is only needed in the -mm tree.

ipc/mqueue.c +1 -1
index 691cfee..c246c83 100644
@@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
 						ns_of_pid(info->notify_owner));
 			sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
 						current_cred(), current_uid());
-			rcu_read_lock();
+			rcu_read_unlock();
 
 			kill_pid_info(info->notify.sigev_signo,
 				      &sig_i, info->notify_owner);