Skip to contentSkip to conversation

x86, amd: Kill misleading message about enablement of IO access to PCI ECS

PATCH New Andreas Herrmann 1 participant 1 message Dec 2, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, amd: Kill misleading message about enablement of IO access to PCI ECS

From: Andreas Herrmann <[email protected]>

Commit 24d9b70b8c679264756a6980e668b96b3f964826 (x86: Use PCI method for enabling AMD extended config space before MSR method) added a message when IO access to PCI ECS was enabled via access to the NB_CFG PCI register. This can lead to a bogus message like

[    0.365177] Extended Config Space enabled on 0 nodes

which is misleading because IO ECS access is subsequently enabled for AMD CPUs (that support this) by modifying the corresponding NB_CFG MSR.

Furthermore it's not "Extended Config Space" that is enabled by this register setting. It's the IO access that is enabled for extended configruation space.

IMHO the ambiguous message needs to be cancelled.

Cc Jan Beulich <[email protected]>
Cc Robert Richter <[email protected]>
---
 arch/x86/pci/amd_bus.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/pci/amd_bus.c +0 -1
index 026e493..7b7a897 100644
@@ -403,7 +403,6 @@ static void __init pci_enable_pci_io_ecs(void)
 			++n;
 		}
 	}
-	pr_info("Extended Config Space enabled on %u nodes\n", n);
 #endif
 }
 
Signature · 1 line
1.7.8.rc4