Skip to contentSkip to conversation

Build breakage in sdhci-s3c

DISCUSSION Mark Brown 3 participants 5 messages Dec 2, 2011 – Dec 3, 2011 MMC, SD and SDIO

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

The mmc and therefore -next currently fail to build on Samsung platforms due to commit 666b6a (mmc: sdhci-s3c: Add pm_caps into SD/MMC host) which added use of a new field pm_caps in the platform data without actually adding that field to the struct. I guess there's a separate patch floating about somewhere which adds the field but it's not in -next and both commits should be going in via the same tree to avoid bisection breakage - ideally both the field and its use should be added as part of a single commit.

#1 lore raw

Hi Kukjin

I checked out your git to look into Mark's email.

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-next

and I found out that the following patch wasn't applied This patch was acked by you and Thomas.

http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps into platform data

Could you help me to solve the below problem ?

Thanks
Sangwook

Quoted 8 lines · Mark Brown

The mmc and therefore -next currently fail to build on Samsung platforms due to commit 666b6a (mmc: sdhci-s3c: Add pm_caps into SD/MMC host) which added use of a new field pm_caps in the platform data without actually adding that field to the struct.  I guess there's a separate patch floating about somewhere which adds the field but it's not in -next and both commits should be going in via the same tree to avoid bisection breakage - ideally both the field and its use should be added as part of a single commit.

author
#2 lore raw
Quoted 8 lines · Sangwook Lee

and I found out that the following patch wasn't applied This patch was acked by you and Thomas.

http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps into platform data

Could you help me to solve the below problem ?

Probably the simplest/best solution here is for Chris to apply this patch with Kukjin and Thomas' acks to the mmc tree.

#3 lore raw

+Thomas

Quoted 17 lines · Mark Brown
Quoted 8 lines · Sangwook Lee

and I found out that the following patch wasn't applied This  patch was acked by you and Thomas.

http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps into platform data

Could you help me to solve the below problem ?

Probably the simplest/best solution here is for Chris to apply this patch with Kukjin and Thomas' acks to the mmc tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

#4 lore raw
In reply to Mark Brown
Quoted 6 lines · Mark Brown
Quoted 2 lines · Sangwook Lee

and I found out that the following patch wasn't applied This patch was acked by you and Thomas.

Quoted 8 lines
Quoted 5 lines

http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps into platform data

Could you help me to solve the below problem ?

Probably the simplest/best solution here is for Chris to apply this patch with Kukjin and Thomas' acks to the mmc tree.

Uhm...it is due to late pushing from my local, I need to sort out my tree now :(

Anyway, Mark's suggestion makes sense, in this case. Because it can be happened during merge window even though I solve/push it now.

Hi Chris,
Could you please pick up Sangwook Lee's '[PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps into platform data' with my ack?

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.