PIP405: build warnings
Dear Denis,
the PIP405 board throws some build warnings:
Configuring for PIP405 board...../common/isa.c: In function 'handle_isa_int':../common/isa.c:385:21: warning: variable 'isr2' set but not used [-Wunused-but-set-variable] ../common/isa.c:385:16: warning: variable 'isr1' set but not used [-Wunused-but-set-variable]
Are you going to fix these, or can we assume this board is dead and can be removed?
Thanks.
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A witty saying proves nothing, but saying something pointless gets people's attention.
PATCH 1/1 board/mpl/common/isa.c: Fix GCC 4.6 build warnings
Fix:../common/isa.c: In function 'handle_isa_int':../common/isa.c:385:21: warning: variable 'isr2' set but not used [-Wunused-but-set-variable]../common/isa.c:385:16: warning: variable 'isr1' set but not used [-Wunused-but-set-variable]
--- board/mpl/common/isa.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
board/mpl/common/isa.c +3 -3
@@ -382,12 +382,12 @@ void init_8259A(void)int handle_isa_int (void ) {unsigned long irqack; -unsigned char isr1,isr2,irq; +unsigned char irq;/* first we acknokledge the int via the PCI bus */ irqack=in32 (PCI_INT_ACK_ADDR );/* now we get the ISRs */ - isr2=in8 (ISR_2 ); - isr1=in8 (ISR_1 ); +in8 (ISR_2 ); +in8 (ISR_1 ); irq=(unsigned char )irqack; irq-=32 ;/* if((irq==7)&&((isr1&0x80)==0)) {
Signature · 1 line
1.7.4.4
Wolfgang Denk
AppliedPATCH 1/1 board/mpl/common/isa.c: Fix GCC 4.6 build warnings
Dear =?UTF-8?q?David=20M=C3=BCller?=,
Quoted 7 lines · In message <[email protected]> you wrote:
Fix:
../common/isa.c: In function 'handle_isa_int':../common/isa.c:385:21: warning: variable 'isr2' set but not used [-Wunused-but-set-variable]../common/isa.c:385:16: warning: variable 'isr1' set but not used [-Wunused-but-set-variable]
Quoted 5 lines
Signed-off-by David Mueller <[email protected]>--- board/mpl/common/isa.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Even historians fail to learn from history -- they repeat the same mistakes. -- John Gill, "Patterns of Force", stardate 2534.7