i386: less assembly in strlen()
PATCH 1/1 i386: less assembly in strlen()
Current i386 strlen() hardcodes NOT/DEC sequence. DEC is mentioned to be suboptimal on Core2. So, put only REPNE SCASB sequence in assembly, compiler can do the rest.
The difference in generated code is like below (MCORE2=y):
<strlen>: push %edi mov $0xffffffff,%ecx mov %eax,%edi xor %eax,%eax repnz scas %es:(%edi),%al not %ecx - dec %ecx - mov %ecx,%eax + lea -0x1(%ecx),%eax pop %edi ret
---
arch/x86/lib/string_32.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
arch/x86/lib/string_32.c +3 -5
@@ -164,15 +164,13 @@ EXPORT_SYMBOL(strchr);size_t strlen (const char *s) {int d0; -int res; +size_t res; asmvolatile ("repne\n\t" -"scasb\n\t" -"notl %0\n\t" -"decl %0" +"scasb" :"=c" (res),"=&D" (d0) :"1" (s),"a" (0 ),"0" (0xffffffffu ) :"memory" ); -return res; +return ~res -1 ; }EXPORT_SYMBOL (strlen);#endif
[tip:x86/asm] x86/i386: Use less assembly in strlen(), speed things up a bit
Commit-ID: 890890cb8e415e1e7a61bfe3c8e246f710196824 Gitweb: http://git.kernel.org/tip/890890cb8e415e1e7a61bfe3c8e246f710196824 Author: Alexey Dobriyan <[email protected]> AuthorDate: Sun, 11 Dec 2011 21:13:19 +0300 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 12 Dec 2011 18:33:42 +0100
x86/i386: Use less assembly in strlen(), speed things up a bit
Current i386 strlen() hardcodes NOT/DEC sequence. DEC is mentioned to be suboptimal on Core2. So, put only REPNE SCASB sequence in assembly, compiler can do the rest.
The difference in generated code is like below (MCORE2=y):
<strlen>: push %edi mov $0xffffffff,%ecx mov %eax,%edi xor %eax,%eax repnz scas %es:(%edi),%al not %ecx - dec %ecx - mov %ecx,%eax + lea -0x1(%ecx),%eax pop %edi ret
--- arch/x86/lib/string_32.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)
arch/x86/lib/string_32.c +3 -5
@@ -164,15 +164,13 @@ EXPORT_SYMBOL(strchr);size_t strlen (const char *s) {int d0; -int res; +size_t res; asmvolatile ("repne\n\t" -"scasb\n\t" -"notl %0\n\t" -"decl %0" +"scasb" :"=c" (res),"=&D" (d0) :"1" (s),"a" (0 ),"0" (0xffffffffu ) :"memory" ); -return res; +return ~res -1 ; }EXPORT_SYMBOL (strlen);#endif
Re: [tip:x86/asm] x86/i386: Use less assembly in strlen(), speed things up a bit
Quoted 2 lines · tip-bot for Alexey Dobriyan
x86/i386: Use less assembly in
strlen(), speed things up a bit
We could probably remove the thing entirely, and just use the generic strlen. Some of the rep instruction usage is just purely historic, there's little point.
Using "repne; scasb" is possibly worth it when inlined. And especially with the change in this patch-set, where inlining also combines with things like expression simplification, and then things like "strlen(s)+1" (common for sizing allocations) the compiler can actually remove the "-1" part entirely. Then the advantage of 'repne scas' is that it's short.
But for out-of-line, we might actually be better off with just a traditional loop. Not because we can do multiple bytes in a go (most kernel strings are likely short enough that it's not a big deal), but simply because 'repne scas' is not generally all that fast.
I dunno. strlen() usually isn't very hot, so it probably doesn't matter. The really hot paths tend to do something like computing a hash at the same time as checking the length of the string or need something more complex anyway (ie the "hash and find '\0' or '/' in a pathname" that path walking does). Pure strlen() is reasonably rare.
So it probably doesn't matter. The patch looks like a nice cleanup.
Linus