Skip to contentSkip to conversation

driver-core: implement 'sysdev' functionality for regular

DISCUSSION Dan Carpenter 1 participant 1 message Dec 16, 2011 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Kay Sievers,

This is a semi-automatic email about new static checker warnings.

The patch ca22e56debc5: "driver-core: implement 'sysdev' functionality for regular devices and buses" from Dec 14, 2011, leads to the following Smatch complaint:

drivers/base/bus.c +1200 subsys_interface_unregister()
warn: variable dereferenced before check 'sif' (see line 1196)

drivers/base/bus.c
1195 {

  1196		struct bus_type *subsys = sif->subsys;
                                          ^^^^^^^^^^^

New dereference.

1197 struct subsys_dev_iter iter;
1198 struct device *dev;
1199
1200 if (!sif)

                    ^^^^

New check.

1201 return;
1202

regards,
dan carpenter