Skip to contentSkip to conversation

nohz: Remove update_ts_time_stat from tick_nohz_start_idle

PATCH RESEND New Michal Hocko 1 participant 1 message Dec 18, 2011 Nohz, dynticks support

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 nohz: Remove update_ts_time_stat from tick_nohz_start_idle

There is no reason to call update_ts_time_stat from tick_nohz_start_idle anymore (after e0e37c20 sched: Eliminate the ts->idle_lastupdate field) when we updated idle_lastupdate unconditionally.

We haven't set idle_active yet and do not provide last_update_time so the whole call end up being just 2 wasted branches.

---
 kernel/time/tick-sched.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/time/tick-sched.c +0 -2
index 4042064..be3cab0 100644
@@ -186,8 +186,6 @@ static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts)
 
 	now = ktime_get();
 
-	update_ts_time_stats(cpu, ts, now, NULL);
-
 	ts->idle_entrytime = now;
 	ts->idle_active = 1;
 	sched_clock_idle_sleep_event();
Signature · 1 line
1.7.7.3