Skip to contentSkip to conversation

random: use arch-specific RNG to initialize the entropy store

PATCH New Theodore Ts'o 1 participant 1 message Dec 22, 2011 1 message not in the archive Random number driver

lore
Share & tools
lore

Theodore Ts'o

author maintainer
#1 lore raw

PATCH 1/1 random: use arch-specific RNG to initialize the entropy store

In reply to a message not in the archive

If there is an architecture-specific random number generator (such as RDRAND for Intel architectures), use it to initialize /dev/random's entropy stores. Even in the worst case, if RDRAND is something like AES(NSA_KEY, counter++), it won't hurt, and it will definitely help against any other adversaries.

---
 drivers/char/random.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/char/random.c +6 -0
index 6035ab8..f10780a 100644
@@ -961,6 +961,7 @@ EXPORT_SYMBOL(get_random_bytes);
  */
 static void init_std_data(struct entropy_store *r)
 {
+	int i;
 	ktime_t now;
 	unsigned long flags;
 
@@ -970,6 +971,11 @@ static void init_std_data(struct entropy_store *r)
 
 	now = ktime_get_real();
 	mix_pool_bytes(r, &now, sizeof(now));
+	for (i = r->poolinfo->poolwords; i; i--) {
+		if (!arch_get_random_long(&flags))
+			break;
+		mix_pool_bytes(r, &flags, sizeof(flags));
+	}
 	mix_pool_bytes(r, utsname(), sizeof(*(utsname())));
 }
 
Signature · 1 line
1.7.8.11.gefc1f.dirty