tracing: adjust shrink_slab beginning trace event name
Subsystems (4)
PATCH 1/1 tracing: adjust shrink_slab beginning trace event name
While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
<tracepoint-name>_begin
<tarcepoint-name>_end
However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.
--- include/trace/events/vmscan.h | 2 +- mm/vmscan.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
include/trace/events/vmscan.h +1 -1
@@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_reTP_ARGS (nr_reclaimed) ); -TRACE_EVENT(mm_shrink_slab_start, +TRACE_EVENT(mm_shrink_slab_begin, TP_PROTO(struct shrinker *shr, struct shrink_control *sc, long nr_objects_to_shrink, unsigned long pgs_scanned, unsigned long lru_pgs, unsigned long cache_items,
mm/vmscan.c +1 -1
@@ -301,7 +301,7 @@ unsigned long shrink_slab(struct shrink_control *shrink,if (total_scan > max_pass *2 ) total_scan = max_pass *2 ; -trace_mm_shrink_slab_start (shrinker, shrink, nr, +trace_mm_shrink_slab_begin (shrinker, shrink, nr, nr_pages_scanned, lru_pages, max_pass, delta, total_scan);
Signature · 8 lines
1.7.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
2011/12/23 Rafael Aquini <[email protected]>:
Quoted 7 lines
While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
<tracepoint-name>_begin
<tarcepoint-name>_endHowever, the 'beginning' tracing event for
shrink_slab()did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.Signed-off-by Rafael Aquini <[email protected]>
I don't think it's big issue. but seems no harm change.
Quoted 34 lines
---
include/trace/events/vmscan.h | 2 +-
mm/vmscan.c | 2 +-2 files changed, 2 insertions(+), 2 deletions(-)include/trace/events/vmscan.h +1
-1@@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re TP_ARGS(nr_reclaimed) ); -TRACE_EVENT(mm_shrink_slab_start, +TRACE_EVENT(mm_shrink_slab_begin, TP_PROTO(struct shrinker *shr, struct shrink_control *sc, long nr_objects_to_shrink, unsigned long pgs_scanned, unsigned long lru_pgs, unsigned long cache_items,mm/vmscan.c +1
-2@@ -301,7 +301,7 @@ unsigned long shrink_slab(struct shrink_control *shrink, if (total_scan > max_pass * 2) total_scan = max_pass * 2; - trace_mm_shrink_slab_start(shrinker, shrink, nr, + trace_mm_shrink_slab_begin(shrinker, shrink, nr, nr_pages_scanned, lru_pages, max_pass, delta, total_scan); --1.7.7.4
Quoted 6 lines
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 7 lines · Rafael Aquini
While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
<tracepoint-name>_begin
<tarcepoint-name>_endHowever, the 'beginning' tracing event for
shrink_slab()did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.Signed-off-by Rafael Aquini <[email protected]>
Signature · 9 lines
Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
<tracepoint-name>_begin
<tarcepoint-name>_end
However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.
--- include/trace/events/vmscan.h | 2 +- mm/vmscan.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
include/trace/events/vmscan.h +1 -1
@@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_reTP_ARGS (nr_reclaimed) ); -TRACE_EVENT(mm_shrink_slab_start, +TRACE_EVENT(mm_shrink_slab_begin, TP_PROTO(struct shrinker *shr, struct shrink_control *sc, long nr_objects_to_shrink, unsigned long pgs_scanned, unsigned long lru_pgs, unsigned long cache_items,
mm/vmscan.c +1 -1
@@ -325,7 +325,7 @@ unsigned long shrink_slab(struct shrink_control *shrink,if (total_scan > max_pass *2 ) total_scan = max_pass *2 ; -trace_mm_shrink_slab_start (shrinker, shrink, nr, +trace_mm_shrink_slab_begin (shrinker, shrink, nr, nr_pages_scanned, lru_pages, max_pass, delta, total_scan);
Signature · 8 lines
1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Rik van Riel
Reviewed-byQuoted 9 lines · Rafael Aquini
While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
<tracepoint-name>_begin
<tarcepoint-name>_endHowever, the 'beginning' tracing event for
shrink_slab()did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.Signed-off-by Rafael Aquini<[email protected]>Reviewed-by Minchan Kim<[email protected]>Acked-by KOSAKI Motohiro<[email protected]>
Signature · 8 lines
All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>