gfs2: make some sizes unsigned in set_recover_size()
Subsystems (2)
PATCH 1/1 gfs2: make some sizes unsigned in set_recover_size()
ls->ls_recover_size is uint32_t so old_size and new_size should be unsigned as well. Otherwise a large value could count as a negative and we could get past the "if (old_size >= max_jid + 1)" check by mistake.
Signed-off-by Dan Carpenter <[email protected]>
fs/gfs2/lock_dlm.c +2 -1
@@ -886,7 +886,8 @@ static int set_recover_size(struct gfs2_sbd *sdp, struct dlm_slot *slots,struct lm_lockstruct *ls = &sdp->sd_lockstruct;uint32_t *submit =NULL ;uint32_t *result =NULL ; -int i, max_jid, old_size, new_size; +uint32_t old_size, new_size; +int i, max_jid; max_jid =0 ;for (i =0 ; i < num_slots; i++) {
Quoted 2 lines
[patch] dlm: le32 vs le16
gfs2: make some sizes unsigned inset_recover_size()
Thanks, I've folded in both of those.
Dave