Skip to contentSkip to conversation

Add Thinkpad SL510 to pci=nocrs blacklist

PATCH Dave Jones 3 participants 3 messages Jan 4, 2012 – Jan 11, 2012

Subsystems (3)
x86 ACPI PCI
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Enabling CRS by default breaks suspend on the Thinkpad SL510. Details in https://bugzilla.redhat.com/show_bug.cgi?id=769657

Reported-by Stefan Kirrmann <[email protected]>
Signed-off-by Dave Jones <[email protected]>
arch/x86/pci/acpi.c renamed from arch/x86/pci/acpi.c~ +10 -0
@@ -72,6 +72,16 @@ static const struct dmi_system_id pci_us
 			DMI_MATCH(DMI_BOARD_NAME, "0M273C"),
 		},
 	},
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
+	{
+		.callback = set_nouse_crs,
+		.ident = "Thinkpad SL510",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_BOARD_NAME, "2847DFG"),
+			DMI_MATCH(DMI_BIOS_VERSION, "6JET85WW (1.43 )"),
+		},
+	},
 	{}
 };
#1 lore raw
Quoted 17 lines · On Wed, 4 Jan 2012 11:30:52 -0500 Dave Jones <[email protected]> wrote:

Enabling CRS by default breaks suspend on the Thinkpad SL510. Details in https://bugzilla.redhat.com/show_bug.cgi?id=769657

Reported-by Stefan Kirrmann <[email protected]>
Signed-off-by Dave Jones <[email protected]>
arch/x86/pci/acpi.c renamed from arch/x86/pci/acpi.c~ +3 -0
@@ -72,6 +72,16 @@ static const struct dmi_system_id pci_us
 			DMI_MATCH(DMI_BOARD_NAME, "0M273C"),
 		},
 	},
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
+	{
+		.callback = set_nouse_crs,

arch/x86/pci/acpi.c static const struct dmi_system_id pci_us · line 87

Quoted 10 lines
arch/x86/pci/acpi.c renamed from arch/x86/pci/acpi.c~ +7 -0
+		.ident = "Thinkpad SL510",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_BOARD_NAME, "2847DFG"),
+			DMI_MATCH(DMI_BIOS_VERSION, "6JET85WW (1.43 )"),
+		},
+	},
 	{}
 };

Ah I see the Thinkpad patch now... applied this one too. Thanks.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
maintainer
#2 lore raw
Quoted 24 lines · Jesse Barnes
Quoted 21 lines · On Wed, 4 Jan 2012 11:30:52 -0500 Dave Jones <[email protected]> wrote:

Enabling CRS by default breaks suspend on the Thinkpad SL510. Details in https://bugzilla.redhat.com/show_bug.cgi?id=769657

Reported-by Stefan Kirrmann <[email protected]>
Signed-off-by Dave Jones <[email protected]>
arch/x86/pci/acpi.c      2011-12-30 14:45:09.296198024 -0500 renamed from arch/x86/pci/acpi.c~     2011-12-30 14:42:43.495717907 -0500 +9 -0
@@ -72,6 +72,16 @@ static const struct dmi_system_id pci_us
                       DMI_MATCH(DMI_BOARD_NAME, "0M273C"),
               },
       },
+     /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
+     {
+             .callback = set_nouse_crs,
+             .ident = "Thinkpad SL510",
+             .matches = {
+                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                     DMI_MATCH(DMI_BOARD_NAME, "2847DFG"),
+                     DMI_MATCH(DMI_BIOS_VERSION, "6JET85WW (1.43 )"),
+             },
Quoted 8 lines

arch/x86/pci/acpi.c      2011-12-30 14:45:09.296198024 -0500 static const struct dmi_system_id pci_us · line 87

Quoted 6 lines
arch/x86/pci/acpi.c      2011-12-30 14:45:09.296198024 -0500 renamed from arch/x86/pci/acpi.c~     2011-12-30 14:42:43.495717907 -0500 +1 -0
+     },
       {}
  };

Ah I see the Thinkpad patch now... applied this one too.   Thanks.

+linux-pci

I think we should hold off on this one, too. We (at least I) don't understand the root cause here.

Bjorn