perf: fix strlen() bug in perf_event__synthesize_event_type()

PATCH New Stephane Eranian 1 participant 1 message Jan 19, 2012 perf events

lore

Share & tools

lore

Stephane Eranian

author

2012-01-19 21:43 UTC #0 lore raw

PATCH 1/1 perf: fix strlen() bug in perf_event__synthesize_event_type()

The event_type record has a max length for the event name. It's called MAX_EVENT_NAME.

The name may be truncated to fit the max length. But the header.size still reflects the original name length. If that length is > MAX_EVENT_NAME, then the header.size field is bogus. Fix this by using the length of the name after the potential truncation.

Signed-off-by Stephane Eranian <[email protected]>

---

tools/perf/util/header.c +1 -1

index 3e7e0b0..ecd7f4d 100644
@@ -2105,7 +2105,7 @@ int perf_event__synthesize_event_type(struct perf_tool *tool,
 	strncpy(ev.event_type.event_type.name, name, MAX_EVENT_NAME - 1);
 
 	ev.event_type.header.type = PERF_RECORD_HEADER_EVENT_TYPE;
-	size = strlen(name);
+	size = strlen(ev.event_type.event_type.name);
 	size = ALIGN(size, sizeof(u64));
 	ev.event_type.header.size = sizeof(ev.event_type) -
 		(sizeof(ev.event_type.event_type.name) - size);