Skip to contentSkip to conversation

qcserial: remove unused "debug" parameter

PATCH In review Thomas Tuttle 1 participant 2 messages Feb 1, 2012 1 message not in the archive

Subsystems (3)
USB TTY layer and serial drivers USB serial
lore
Share & tools
lore

Thomas Tuttle

author
#0 lore raw

PATCH 3/4 qcserial: remove unused "debug" parameter

Signed-off-by Thomas Tuttle <[email protected]>
---
 drivers/usb/serial/qcserial.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/usb/serial/qcserial.c +0 -2
index 5a817d6..0f549c6 100644
@@ -22,8 +22,6 @@
 #define DRIVER_AUTHOR "Qualcomm Inc"
 #define DRIVER_DESC "Qualcomm USB Serial driver"
 
-static bool debug;
-
 static const struct usb_device_id id_table[] = {
 	{USB_DEVICE(0x05c6, 0x9211)},	/* Acer Gobi QDL device */
 	{USB_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

@@ -298,6 +296,3 @@ module_exit(qcexit);
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL v2");

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw

...ignore this patch. debug is not unused -- the dbg macro references it, but is defined elsewhere.

Sorry for the noise; turns out I was not actually building my modified tree. >.<

Quoted 26 lines · Thomas Tuttle
Signed-off-by Thomas Tuttle <[email protected]>

---
 drivers/usb/serial/qcserial.c |    5 -----

 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/usb/serial/qcserial.c +0 -2
index 5a817d6..0f549c6 100644
@@ -22,8 +22,6 @@
  #define DRIVER_AUTHOR "Qualcomm Inc"
  #define DRIVER_DESC "Qualcomm USB Serial driver"
 
-static bool debug;
-
  static const struct usb_device_id id_table[] = {

       {USB_DEVICE(0x05c6, 0x9211)},   /* Acer Gobi QDL device */ {USB_DEVICE(0x05c6, 0x9212)},   /* Acer Gobi Modem Device */

drivers/usb/serial/qcserial.c +0 -4
@@ -298,6 +296,3 @@ module_exit(qcexit);
  MODULE_AUTHOR(DRIVER_AUTHOR);
  MODULE_DESCRIPTION(DRIVER_DESC);
  MODULE_LICENSE("GPL v2");
-
-module_param(debug, bool, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(debug, "Debug enabled or not");
--
Quoted 2 lines

1.7.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html