qcserial: don't enable autosuspend

PATCH In review Thomas Tuttle 2 participants 2 messages Feb 1, 2012 – Feb 2, 2012 1 message not in the archive

Subsystems (3)

USB TTY layer and serial drivers USB serial

lore

Share & tools

lore

Thomas Tuttle

author

2012-02-01 21:07 UTC #0 lore raw

PATCH 4/4 qcserial: don't enable autosuspend

We've found that qcserial devices will not always wake up reliably from autosuspend, so disable it.

Signed-off-by Thomas Tuttle <[email protected]>

---
 drivers/usb/serial/qcserial.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

drivers/usb/serial/qcserial.c +0 -1

index 0f549c6..be9050f 100644
@@ -135,8 +135,6 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id)
 
 	spin_lock_init(&data->susp_lock);
 
-	usb_enable_autosuspend(serial->dev);

A message that is not in the archive (sent off-list or not yet received): [email protected]

Oliver Neukum

2012-02-02 08:40 UTC #2 lore raw

Am Mittwoch, 1. Februar 2012, 22:07:45 schrieb Thomas Tuttle:

Quoted 2 lines

We've found that qcserial devices will not always wake up reliably from autosuspend, so disable it.

This might quite hurt power consumption. Can you also solve this with the RESET_RESUME quirk?

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html