Skip to contentSkip to conversation

params: <level>_initcall-like kernel parameters

PATCH New Dan Carpenter 3 participants 5 messages Feb 2, 2012 – Feb 7, 2012

lore
Share & tools
lore
#0 lore raw

Hello Pawel Moll,

The patch b41c2e271944: "params: <level>_initcall-like kernel parameters" from Dec 12, 2011, leads to the following warning:
init/main.c:749 do_initcall_level()
error: buffer overflow 'initcall_level_names' 7 <= 7

743 static void __init do_initcall_level(int level) 744 {
745 extern const struct kernel_param __start___param[], __stop___param[];
746 initcall_t *fn;
747
748 strcpy(static_command_line, saved_command_line);
749 parse_args(initcall_level_names[level],

                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^

initcall_level_names[] has 7 elements so initcall_level_names[7] is past the end of the array.

   750                     static_command_line, __start___param,
   751                     __stop___param - __start___param,
   752                     level, level,
   753                     ignore_unknown_bootoption);
   754  
   755          for (fn = initcall_levels[level]; fn < initcall_levels[level+1]; fn++)
   756                  do_one_initcall(*fn);
   757  }
   758  
   759  static void __init do_initcalls(void)
   760  {
   761          int level;
   762  
   763          for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++)
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

initcall_levels[] has 9 elements so level is 0-7 here.

   764                  do_initcall_level(level);
   765  }

regards,
dan carpenter

#1 lore raw

Morning,

Quoted 31 lines · Dan Carpenter

The patch b41c2e271944: "params: <level>_initcall-like kernel parameters" from Dec 12, 2011, leads to the following warning:
init/main.c:749 do_initcall_level()
error: buffer overflow 'initcall_level_names' 7 <= 7

   743  static void __init do_initcall_level(int level)
   744  {
   745          extern const struct kernel_param __start___param[], __stop___param[];
   746          initcall_t *fn;
   747  
   748          strcpy(static_command_line, saved_command_line);
   749          parse_args(initcall_level_names[level],
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^

initcall_level_names[] has 7 elements so initcall_level_names[7] is past the end of the array.

   750                     static_command_line, __start___param,
   751                     __stop___param - __start___param,
   752                     level, level,
   753                     ignore_unknown_bootoption);
   754  
   755          for (fn = initcall_levels[level]; fn < initcall_levels[level+1]; fn++)
   756                  do_one_initcall(*fn);
   757  }
   758  
   759  static void __init do_initcalls(void)
   760  {
   761          int level;
   762  
   763          for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++)
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 4 lines

initcall_levels[] has 9 elements so level is 0-7 here.

   764                  do_initcall_level(level);
   765  }

You're right, of course! The initcall_level_names is missing "early parameters" string as the first element of the array. Well spotted - may I asked what tool did you use to get this message?

Rusty, do you want me to re-send the patch with this string fixed? I think you have rebased it on top of your bool-param series?

Thanks for your time!

Paweł

#2 lore raw
Quoted 4 lines · Pawel Moll

You're right, of course! The initcall_level_names is missing "early parameters" string as the first element of the array. Well spotted - may I asked what tool did you use to get this message?

It's a Smatch thing, but it requires the database to be set up first. It's a new-ish feature. I should clean up my build scripts and publish them...

regards,
dan carpenter

#3 lore raw
In reply to Pawel Moll
Quoted 6 lines · Pawel Moll

You're right, of course! The initcall_level_names is missing "early parameters" string as the first element of the array. Well spotted - may I asked what tool did you use to get this message?

Rusty, do you want me to re-send the patch with this string fixed? I think you have rebased it on top of your bool-param series?

An incremental patch is preferred. I can fold it once it's done.

Thanks,
Rusty.

#4 lore raw

PATCH 1/1 params: Add missing init level name

The initcall_level_names array did not contain name of the "virtual" level 0 (early paramters). Fixed.

---
 init/main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
init/main.c +1 -0
index 8e4060c..b229ee6 100644
@@ -726,6 +726,7 @@ static initcall_t *initcall_levels[] __initdata = {
 };
 
 static char *initcall_level_names[] __initdata = {
+	"early parameters",
 	"core parameters",
 	"postcore parameters",
 	"arch parameters",
Signature · 1 line
1.7.5.4