fs/vfat: add *.cmd to filenames listed as executable by mount option "showexec"
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · OGAWA Hirofumi
Quoted 6 lines · Roland Eggner
The mount option "showexec" provides a somewhat more native view of vfat
filesystems: only filenames *.exe *.com *.bat are listed as executable, rather than all files. This patch adds filenames *.cmd to those listed as executable. *.cmd are usually scripts associated with the shell "cmd.exe", which has been the default shell in several OS versions of its vendor.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Roland Eggner <[email protected]>---
Hm, this may be good for someone, but this may not be for someone. So, this probably should be option if someone really care it.
I'm not thinking about how though...
Think of VM images of recent versions of the FAT originating OS: currently "showexec" will miss roughly half of the files, for which it is intended for. IMHO this patch provides a very cheap completion of a feature of the vfat kernel module. Cheap in terms of only 9 characters additional source code.
If you really see an advantage in the current, incomplete state of the "showexec" feature, compared to the proposed, completed state: please elaborate your objection.
Quoted 22 lines
Quoted 22 lines
Documentation/filesystems/vfat.txt +1
-1@@ -114,7 +114,7 @@ showexec -- If set, the execute permission bits of the file will be allowed only if the extension part of the name is .EXE, - .COM, or .BAT. Not set by default. + .COM, .BAT or .CMD. Not set by default. debug -- Can be set, but unused by the current implementation.fs/fat/inode.c +1
-1@@ -326,7 +326,7 @@ struct inode *fat_iget(struct super_blocstatic int is_exec (unsigned char *extension) { -unsigned char *exe_extensions ="EXECOMBAT" , *walk; +unsigned char *exe_extensions ="EXECOMBATCMD" , *walk;for (walk = exe_extensions; *walk; walk +=3 )if (!strncmp (extension, walk,3 ))
Signature · 1 line
Roland Eggner <[email protected]>
Quoted 20 lines · Roland Eggner
Quoted 11 lines · OGAWA Hirofumi
Quoted 9 lines · Roland Eggner
The mount option "showexec" provides a somewhat more native view of vfat
filesystems: only filenames *.exe *.com *.bat are listed as executable, rather
than all files. This patch adds filenames *.cmd to those listed as executable.
*.cmd are usually scripts associated with the shell "cmd.exe", which has been
the default shell in several OS versions of its vendor.Quoted 8 lines
Quoted 2 lines
Signed-off-by Roland Eggner <[email protected]>---
Hm, this may be good for someone, but this may not be for someone. So, this probably should be option if someone really care it.
I'm not thinking about how though...
Quoted 8 lines
Think of VM images of recent versions of the FAT originating OS: currently "showexec" will miss roughly half of the files, for which it is intended for. IMHO this patch provides a very cheap completion of a feature of the vfat kernel module. Cheap in terms of only 9 characters additional source code.
If you really see an advantage in the current, incomplete state of the "showexec" feature, compared to the proposed, completed state: please elaborate your objection.
You would be happy with adding "cmd", and may think enough. But Someone is not happy with it. And someone want to add "sh", "py", and "pl".
If I have to tackle it, why I have to make happy only your state? I'm not saying current has advantage, I'm saying your patch doesn't make guys happy like current one. It is just moving a place of happiness from a group to an another group, right?
Thanks.
Signature · 1 line
OGAWA Hirofumi <[email protected]>