usb: dwc3: make dwc3_get_device_id() return the id

PATCH Applied Dan Carpenter 3 participants 4 messages Feb 4, 2012 – Feb 6, 2012

Subsystems (3)

USB Kernel janitors DesignWare USB3 DRD IP driver

lore

Share & tools

lore

Dan Carpenter

author

2012-02-04 13:37 UTC #0 lore raw

PATCH 1/1 usb: dwc3: make dwc3_get_device_id() return the id

We always return zero instead of the id we found.

Signed-off-by Dan Carpenter <[email protected]>

---
I don't have this hardware so it's not tested.

drivers/usb/dwc3/core.c +1 -1

index 7c9df63..73df745 100644
@@ -86,7 +86,7 @@ again:
 		id = -ENOMEM;
 	}
 
-	return 0;
+	return id;
 }
 EXPORT_SYMBOL_GPL(dwc3_get_device_id);

Felipe Balbi

Applied

2012-02-06 06:44 UTC #1 lore raw

Quoted 3 lines · Dan Carpenter

We always return zero instead of the id we found.
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks

Quoted 2 lines

---
I don't have this hardware so it's not tested.

This one is so obvious that I can't even believe we haven't seen that before, thanks ;-)

Signature · 1 line

balbi

walter harms

2012-02-06 08:09 UTC #2 lore raw

In reply to Dan Carpenter

Am 06.02.2012 07:44, schrieb Felipe Balbi:

Quoted 5 lines · Dan Carpenter

Quoted 3 lines
We always return zero instead of the id we found.
Signed-off-by Dan Carpenter <[email protected]>

Quoted 8 lines

Applied, thanks
Quoted 2 lines
---
I don't have this hardware so it's not tested.
This one is so obvious that I can't even believe we haven't seen that before, thanks ;-)

i was wondering why the driver worked at all, do you realy need that ?

re,
wh

Felipe Balbi

2012-02-06 08:17 UTC #3 lore raw

In reply to Dan Carpenter

Quoted 10 lines · walter harms

Am 06.02.2012 07:44, schrieb Felipe Balbi:
Quoted 7 lines · Dan Carpenter
Quoted 3 lines
We always return zero instead of the id we found.
Signed-off-by Dan Carpenter <[email protected]>
Applied, thanks

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
---
I don't have this hardware so it's not tested.
This one is so obvious that I can't even believe we haven't seen that before, thanks ;-)
i was wondering why the driver worked at all, do you realy need that ?

as of now we don't have usecases for that. But since it can work on PCIe, I was thinking of building an automated testmachine with two of those devices ;-)

Signature · 1 line

balbi