Skip to contentSkip to conversation

fsl-diu: enable_lcdc() takes a pointer, not struct...

PATCH Al Viro 2 participants 2 messages Feb 5, 2012 Framebuffer layer

lore
Share & tools
lore

Al Viro

author
#0 lore raw

A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...

drivers/video/fsl-diu-fb.c +2 -2
index acf292b..629ae00 100644
@@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
 	struct fsl_diu_data *data;
 
 	data = dev_get_drvdata(&ofdev->dev);
-	disable_lcdc(data->fsl_diu_info[0]);
+	disable_lcdc(&data->fsl_diu_info[0]);
 
 	return 0;
 }
@@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
 	struct fsl_diu_data *data;
 
 	data = dev_get_drvdata(&ofdev->dev);
-	enable_lcdc(data->fsl_diu_info[0]);
+	enable_lcdc(&data->fsl_diu_info[0]);
 
 	return 0;
 }
#1 lore raw
Quoted 3 lines · Al Viro

A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...

This is already fixed in fbdev, although I can't find the patch in the archives (http://marc.info/?l=linux-fbdev&r=3&b 1201&w=2).

Quoted 24 lines
drivers/video/fsl-diu-fb.c +2 -2
index acf292b..629ae00 100644
@@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
  	struct fsl_diu_data *data;
 
  	data = dev_get_drvdata(&ofdev->dev);
-	disable_lcdc(data->fsl_diu_info[0]);
+	disable_lcdc(&data->fsl_diu_info[0]);
 
  	return 0;
  }
@@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
  	struct fsl_diu_data *data;
 
  	data = dev_get_drvdata(&ofdev->dev);
-	enable_lcdc(data->fsl_diu_info[0]);
+	enable_lcdc(&data->fsl_diu_info[0]);
 
  	return 0;
  }
Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale