Skip to contentSkip to conversation

Fix Cross-compiling with KVM support for ARM

PATCH Alexander Graf 1 participant 1 message Feb 9, 2012 5 messages not in the archive KVM

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20120209185643.22453.20492.stgit@ubuntu

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CANM98qJxn5JrCtGOMtuYk+sB4x8-t3c0BGZW8H-LztypHpKjqw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CANM98qKURP89vJDv65DfgbDy2GMUinGcTCnCxh9nCwa75_9AVA@mail.gmail.com

#5 lore raw
Quoted 11 lines · Christoffer Dall

sorry about missing reply-all before

Quoted 8 lines · Alexander Graf
Quoted 2 lines · Christoffer Dall

becuase KVM_CAP_IRQ_ROUTING is only defined when __KVM_HAVE_IOAPIC. kvm/arm does not have this defined.

Then it's not a cross compiling issue, but a header definition issue.

Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

any better way to fix this - I'm completely open to that.

Yes, get rid of conditional CAP definitions. Just always define them :). The number space is linear anyways, so it doesn't make any sense to hide specific constants.

this is a Linux imported header file. I'm not sure about the whole flow here, so consider this patch a hint to the qemu to please help me fix it then...

The flow to fix it is pretty straight forward:

1) make the cap definition unconditional in upstream kvm.git
2) run ./scripts/update-linux-headers.sh

and suddenly everything becomes a lot easier :).

Oh - while at it, why not make _all_ cap definitions unconditional?

Alex