KEYS: testing wrong bit for KEY_FLAG_REVOKED
Subsystems (3)
PATCH v2 1/1 KEYS: testing wrong bit for KEY_FLAG_REVOKED
The test for "if (cred->request_key_auth->flags & KEY_FLAG_REVOKED) {" should actually testing that the (1 << KEY_FLAG_REVOKED) bit is set. The current code actually checks for KEY_FLAG_DEAD.
Signed-off-by Dan Carpenter <[email protected]>
---
v2: the first patch introduced a new variable to avoid breaking the 80
char limit.
security/keys/process_keys.c +2 -1
@@ -657,7 +657,8 @@ try_again: goto error;down_read (&cred->request_key_auth->sem); -if (cred->request_key_auth->flags &KEY_FLAG_REVOKED ) { +if (test_bit (KEY_FLAG_REVOKED , + &cred->request_key_auth->flags)) { key_ref =ERR_PTR (-EKEYREVOKED ); key =NULL ; }else {