Skip to contentSkip to conversation

ARM: OMAP2+: Fix build issues with missing include of linux/bug.h

PATCH Superseded Tony Lindgren 2 participants 3 messages Mar 8, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Tony Lindgren

author maintainer
#0 lore raw

PATCH v2 1/1 ARM: OMAP2+: Fix build issues with missing include of linux/bug.h

Otherwise we can get the following if bug.h is not included from kernel.h:

arch/arm/mach-omap2/powerdomain-common.c:
In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Signed-off-by Tony Lindgren <[email protected]>
arch/arm/mach-omap2/clkt_clksel.c +1 -0
index e25364d..04d551b 100644
@@ -43,6 +43,7 @@
 #include <linux/errno.h>
 #include <linux/clk.h>
 #include <linux/io.h>
+#include <linux/bug.h>
 
 #include <plat/clock.h>
arch/arm/mach-omap2/powerdomain-common.c +1 -0
index f97afff..c0aeabf 100644
@@ -13,6 +13,7 @@
 
 #include <linux/errno.h>
 #include <linux/kernel.h>
+#include <linux/bug.h>
 #include "pm.h"
 #include "cm.h"
 #include "cm-regbits-34xx.h"
arch/arm/mach-omap2/powerdomain2xxx_3xxx.c +1 -0
index 6a17e4c..0f0a9f1 100644
@@ -15,6 +15,7 @@
 #include <linux/io.h>
 #include <linux/errno.h>
 #include <linux/delay.h>
+#include <linux/bug.h>
 
 #include <plat/prcm.h>
arch/arm/mach-omap2/powerdomains3xxx_data.c +1 -0
index 8ef26da..b7ea468 100644
@@ -13,6 +13,7 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/bug.h>
 
 #include <plat/cpu.h>
Applied
#1 lore raw

PATCH v2 1/1 ARM: OMAP2+: Fix build issues with missing include of linux/bug.h

Quoted 9 lines · Tony Lindgren

Otherwise we can get the following if bug.h is not included from kernel.h:

arch/arm/mach-omap2/powerdomain-common.c:
In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Signed-off-by Tony Lindgren <[email protected]>

Applied to next/fixes-non-critical. Thanks!

-Olof

author maintainer
#2 lore raw

PATCH v2 1/1 ARM: OMAP2+: Fix build issues with missing include of linux/bug.h

Quoted 9 lines · Olof Johansson
Quoted 8 lines · Tony Lindgren

Otherwise we can get the following if bug.h is not included from kernel.h:

arch/arm/mach-omap2/powerdomain-common.c:
In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Quoted 3 lines
Quoted 1 line
Signed-off-by Tony Lindgren <[email protected]>

Applied to next/fixes-non-critical. Thanks!

Thanks a lot!

Tony