Skip to contentSkip to conversation

gpio: ep93xx: Remove unused inline function and useless pr_err message

PATCH Applied H Hartley Sweeten 2 participants 2 messages Mar 21, 2012 – Mar 25, 2012 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: ep93xx: Remove unused inline function and useless pr_err message

Minor removal of an unused inline function and a useless pr_err message.

Cc Grant Likely <[email protected]>
Cc Linus Walleij <[email protected]>

---

drivers/gpio/gpio-ep93xx.c +0 -8
index 4ca5642..776b772 100644
@@ -12,8 +12,6 @@
  *  published by the Free Software Foundation.
  */
 
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
@@ -65,11 +63,6 @@ static void ep93xx_gpio_update_int_params(unsigned port)
 		EP93XX_GPIO_REG(int_en_register_offset[port]));
 }
 
-static inline void ep93xx_gpio_int_mask(unsigned line)
-{
-	gpio_int_unmasked[line >> 3] &= ~(1 << (line & 7));
-}
-
 static void ep93xx_gpio_int_debounce(unsigned int irq, bool enable)
 {
 	int line = irq_to_gpio(irq);
@@ -212,7 +205,6 @@ static int ep93xx_gpio_irq_type(struct irq_data *d, unsigned int type)
 		handler = handle_edge_irq;
 		break;
 	default:
-		pr_err("failed to set irq type %d for gpio %d\n", type, gpio);
 		return -EINVAL;
 	}
 
Applied
#1 lore raw
Quoted 5 lines · H Hartley Sweeten

Minor removal of an unused inline function and a useless pr_err message.

Cc Grant Likely <[email protected]>
Cc Linus Walleij <[email protected]>

Applied, thanks.

g.

Quoted 35 lines

---

drivers/gpio/gpio-ep93xx.c +0 -8
index 4ca5642..776b772 100644
@@ -12,8 +12,6 @@
  *  published by the Free Software Foundation.
  */
 
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
@@ -65,11 +63,6 @@ static void ep93xx_gpio_update_int_params(unsigned port)
 		EP93XX_GPIO_REG(int_en_register_offset[port]));
 }
 
-static inline void ep93xx_gpio_int_mask(unsigned line)
-{
-	gpio_int_unmasked[line >> 3] &= ~(1 << (line & 7));
-}
-
 static void ep93xx_gpio_int_debounce(unsigned int irq, bool enable)
 {
 	int line = irq_to_gpio(irq);
@@ -212,7 +205,6 @@ static int ep93xx_gpio_irq_type(struct irq_data *d, unsigned int type)
 		handler = handle_edge_irq;
 		break;
 	default:
-		pr_err("failed to set irq type %d for gpio %d\n", type, gpio);
 		return -EINVAL;
 	}
 
Signature · 2 lines
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.