console class in kvm
kvm used to carry this commit:
commit 4667e6ec0df770867095d8093562d93c94d96ca2
Author: Avi Kivity <[email protected]> Date: Thu Feb 12 11:43:17 2009 +0200
Change virtio-console to PCI_CLASS_OTHERS
As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP (possibly Windows disables acceleration since it fails to find a driver).
This seems to have been dropped. Is the issue gone? Could relevant parties speak up please?
Do we want to merge this commit into qemu.git?
Signature · 1 line
MST
Quoted 1 line · Michael S. Tsirkin
kvm used to carry this commit:
Used to? Which commit reverts this?
Quoted 6 lines
commit
4667e6ec0df770867095d8093562d93c94d96ca2Author: Avi Kivity <[email protected]> Date: Thu Feb 12 11:43:17 2009 +0200Change virtio-console to
PCI_CLASS_OTHERS
Quoted 8 lines
As a
PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP (possibly Windows disables acceleration since it fails to find a driver).Signed-off-by Avi Kivity <[email protected]>This seems to have been dropped. Is the issue gone? Could relevant parties speak up please?
Do we want to merge this commit into qemu.git?
It's an impossible compatibility problem now. I have this sinking feeling that we need to create yet another driver property.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 4 lines · Avi Kivity
Quoted 1 line · Michael S. Tsirkin
kvm used to carry this commit:
Used to? Which commit reverts this?
A merge from qemu.git I would guess.
git log does not seem to show the culprit, I don't know how to find it.
Quoted 9 lines
Quoted 9 lines
commit
4667e6ec0df770867095d8093562d93c94d96ca2Author: Avi Kivity <[email protected]> Date: Thu Feb 12 11:43:17 2009 +0200Change virtio-console to
PCI_CLASS_OTHERSAs a
PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP (possibly Windows disables acceleration since it fails to find a driver).
Quoted 8 lines
Quoted 5 lines
Signed-off-by Avi Kivity <[email protected]>This seems to have been dropped. Is the issue gone? Could relevant parties speak up please?
Do we want to merge this commit into qemu.git?It's an impossible compatibility problem now. I have this sinking feeling that we need to create yet another driver property.
That's easy, we have a class property for this already.
Quoted 2 lines
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 9 lines · Michael S. Tsirkin
Quoted 4 lines · Avi Kivity
Quoted 1 line · Michael S. Tsirkin
kvm used to carry this commit:
Used to? Which commit reverts this?
A merge from qemu.git I would guess.
git log does not seem to show the culprit, I don't know how to find it.
It was e2478f504fff20ad (git log -SPCI_CLASS_OTHERS master -m -p).
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
commit
4667e6ec0df770867095d8093562d93c94d96ca2Author: Avi Kivity <[email protected]> Date: Thu Feb 12 11:43:17 2009 +0200Change virtio-console to
PCI_CLASS_OTHERSAs a
PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP (possibly Windows disables acceleration since it fails to find a driver).Signed-off-by Avi Kivity <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
This seems to have been dropped. Is the issue gone? Could relevant parties speak up please?
Do we want to merge this commit into qemu.git?It's an impossible compatibility problem now. I have this sinking feeling that we need to create yet another driver property.
That's easy, we have a class property for this already.
Yes, d6beee9938.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 29 lines · Avi Kivity
Quoted 9 lines · Michael S. Tsirkin
Quoted 4 lines · Avi Kivity
Quoted 1 line · Michael S. Tsirkin
kvm used to carry this commit:
Used to? Which commit reverts this?
A merge from qemu.git I would guess.
git log does not seem to show the culprit, I don't know how to find it.It was
e2478f504fff20ad(git log -SPCI_CLASS_OTHERS master -m -p).Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
commit
4667e6ec0df770867095d8093562d93c94d96ca2Author: Avi Kivity <[email protected]> Date: Thu Feb 12 11:43:17 2009 +0200Change virtio-console to
PCI_CLASS_OTHERSAs a
PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP (possibly Windows disables acceleration since it fails to find a driver).Signed-off-by Avi Kivity <[email protected]>This seems to have been dropped. Is the issue gone? Could relevant parties speak up please?
Do we want to merge this commit into qemu.git?
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
It's an impossible compatibility problem now. I have this sinking feeling that we need to create yet another driver property.
That's easy, we have a class property for this already.
Yes,
d6beee9938.
Exactly. qemu-kvm used to set the class to CLASS_OTHER while the current code sets it to PCI_CLASS_COMMUNICATION_OTHER. Do we want support for CLASS_OTHER or is it ok to drop it?
Quoted 3 lines
Signature · 2 lines
-- error compiling committee.c: too many arguments to function
Quoted 5 lines · Michael S. Tsirkin
Exactly. qemu-kvm used to set the class to
CLASS_OTHERwhile the current code sets it toPCI_CLASS_COMMUNICATION_OTHER. Do we want support forCLASS_OTHERor is it ok to drop it?
Looks like starting with qemu-kvm-0.11, qemu-kvm matches qemu. I think we can let the compatibility problem with qemu-kvm-0.10 remain.
Signature · 1 line
error compiling committee.c: too many arguments to function