Skip to contentSkip to conversation

clk: remove unnecessary EXPORT_SYMBOL_GPL

PATCH New Shawn Guo 3 participants 4 messages Mar 27, 2012 – Mar 28, 2012 1 message not in the archive

lore
Share & tools
lore

Shawn Guo

author
#1 lore raw

PATCH 2/10 clk: remove unnecessary EXPORT_SYMBOL_GPL

In reply to a message not in the archive
Quoted 12 lines · Andrew Lunn
Quoted 9 lines

Date: Tue, 27 Mar 2012 15:23:21 +0800
From: Shawn Guo <[email protected]>
To: linux-arm-kernel at lists.infradead.org
Cc: Shawn Guo <[email protected]>, Mike Turquette
<[email protected]>
Subject: [PATCH 02/10] clk: remove unnecessary EXPORT_SYMBOL_GPL
Message-ID: <[email protected]>

It makes no sense to have EXPORT_SYMBOL_GPL on static functions.

Hi Shawn

Quoted 9 lines

I agree, exporting static functions makes no sense.

However, i think it would be good to export them. I will probably need to build a clk very similar to the gated clock. I would like to use these functions when building my ops structure and just add wrappers around them where needed.

Could you instead remove the static?

Hmm, I would not.

I have a similar need for clk_divider_ops calls. Instead of exporting every single clk_gate_ops call, we should just export "struct clk_ops clk_gate_ops". That's exactly why I have the patch #4 here.

Signature · 2 lines
Regards,
Shawn
#2 lore raw

PATCH 2/10 clk: remove unnecessary EXPORT_SYMBOL_GPL

Quoted 20 lines · Shawn Guo
Quoted 19 lines · Andrew Lunn
Quoted 9 lines

Date: Tue, 27 Mar 2012 15:23:21 +0800
From: Shawn Guo <[email protected]>
To: linux-arm-kernel at lists.infradead.org
Cc: Shawn Guo <[email protected]>, Mike Turquette
? ? ? ?<[email protected]>
Subject: [PATCH 02/10] clk: remove unnecessary EXPORT_SYMBOL_GPL
Message-ID: <[email protected]>

It makes no sense to have EXPORT_SYMBOL_GPL on static functions.

Hi Shawn

I agree, exporting static functions makes no sense.

However, i think it would be good to export them. I will probably need to build a clk very similar to the gated clock. I would like to use these functions when building my ops structure and just add wrappers around them where needed.

Quoted 7 lines
Quoted 2 lines

Could you instead remove the static?

Hmm, I would not.

I have a similar need for clk_divider_ops calls. ?Instead of exporting every single clk_gate_ops call, we should just export "struct clk_ops clk_gate_ops". ?That's exactly why I have the patch #4 here.

Andrew, does this approach work for you? I prefer it over the EXPORT madness.

Regards,
Mike

#3 lore raw

PATCH 2/10 clk: remove unnecessary EXPORT_SYMBOL_GPL

Quoted 5 lines
Quoted 3 lines

I have a similar need for clk_divider_ops calls. ?Instead of exporting every single clk_gate_ops call, we should just export "struct clk_ops clk_gate_ops". ?That's exactly why I have the patch #4 here.

Andrew, does this approach work for you? I prefer it over the EXPORT madness.

Hi Mike

I think so. I'm waiting for the first 3.4 RC to come out so I've not tried implementing it yet.

Andrew

#4 lore raw

PATCH 2/10 clk: remove unnecessary EXPORT_SYMBOL_GPL

Quoted 10 lines · Andrew Lunn
Quoted 5 lines
Quoted 3 lines

I have a similar need for clk_divider_ops calls. ?Instead of exporting every single clk_gate_ops call, we should just export "struct clk_ops clk_gate_ops". ?That's exactly why I have the patch #4 here.

Andrew, does this approach work for you? ?I prefer it over the EXPORT madness.

Hi Mike

I think so. I'm waiting for the first 3.4 RC to come out so I've not tried implementing it yet.

In that case I'm going to roll it into my fixes branch. I want to send that branch to Arnd ASAP so I can't afford to wait on feedback from -rc1. Please do shout if you find it problematic after -rc1, though.

Thanks,
Mike