Skip to contentSkip to conversation

drm/i915/bios: cleanup return type of intel_parse_bios()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 28, 2012

Subsystems (5)
DRM drivers DRM misc Intel i915 Kernel janitors +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/i915/bios: cleanup return type of intel_parse_bios()

These are unintuitive. These are type bool and return -1 casted to true on failure. Let's just make it return an int. The callers don't care, but let's change this as a cleanup.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/gma500/intel_bios.h +1 -1
index 70f1bf0..4c86a83 100644
@@ -303,7 +303,7 @@ struct bdb_sdvo_lvds_options {
 } __attribute__((packed));
 
 
-extern bool psb_intel_init_bios(struct drm_device *dev);
+extern int psb_intel_init_bios(struct drm_device *dev);
 extern void psb_intel_destroy_bios(struct drm_device *dev);
 
 /*
drivers/gpu/drm/gma500/intel_bios.c +1 -1
index d4d0c5b..b59422e 100644
@@ -231,7 +231,7 @@ static void parse_general_features(struct drm_psb_private *dev_priv,
  *
  * Returns 0 on success, nonzero on failure.
  */
-bool psb_intel_init_bios(struct drm_device *dev)
+int psb_intel_init_bios(struct drm_device *dev)
 {
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	struct pci_dev *pdev = dev->pdev;
drivers/gpu/drm/i915/intel_bios.h +1 -1
index dbda6e3..31c2107 100644
@@ -476,7 +476,7 @@ struct bdb_edp {
 } __attribute__ ((packed));
 
 void intel_setup_bios(struct drm_device *dev);
-bool intel_parse_bios(struct drm_device *dev);
+int intel_parse_bios(struct drm_device *dev);
 
 /*
  * Driver<->VBIOS interaction occurs through scratch bits in
drivers/gpu/drm/i915/intel_bios.c +1 -1
index 8168d8f..9c2b855 100644
@@ -630,7 +630,7 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
  *
  * Returns 0 on success, nonzero on failure.
  */
-bool
+int
 intel_parse_bios(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

These are unintuitive. These are type bool and return -1 casted to true on failure. Let's just make it return an int. The callers don't care, but let's change this as a cleanup.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Daniel Vetter <[email protected]>

... or split it up into psb and i915 so I can merge it through drm-intel-next.
-Daniel

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48