xHCI: use gfp flags from caller instead of GFP_ATOMIC
Subsystems (3)
PATCH v2 1/1 xHCI: use gfp flags from caller instead of GFP_ATOMIC
The caller is allowed to specify the GFP flags for these functions. We should prefer their flags unless we have good reason. For example, if we take a spin_lock ourselves we'd need to use GFP_ATOMIC. But in this case it's safe to use the callers GFP flags.
The callers all pass GFP_ATOMIC here, so this change doesn't affect how the kernel behaves but we may add other callers later and this is a cleanup.
Signed-off-by Dan Carpenter <[email protected]>
---
v2: Rewrote the changelog message.
drivers/usb/host/xhci-ring.c +2 -2
@@ -2734,7 +2734,7 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t mem_flags, urb->dev->speed = USB_SPEED_FULL) urb->interval /=8 ; } -return xhci_queue_bulk_tx (xhci,GFP_ATOMIC , urb, slot_id, ep_index); +return xhci_queue_bulk_tx (xhci, mem_flags, urb, slot_id, ep_index); }/*
@@ -3514,7 +3514,7 @@ int xhci_queue_isoc_tx_prepare(struct xhci_hcd *xhci, gfp_t mem_flags, } ep_ring->num_trbs_free_temp = ep_ring->num_trbs_free; -return xhci_queue_isoc_tx (xhci,GFP_ATOMIC , urb, slot_id, ep_index); +return xhci_queue_isoc_tx (xhci, mem_flags, urb, slot_id, ep_index); }/**** Command Ring Operations ****/
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html