Skip to contentSkip to conversation

Yama: remove an unused variable

PATCH Applied Dan Carpenter 3 participants 3 messages Apr 20, 2012 – Apr 23, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Yama: remove an unused variable

GCC complains that we don't use "one" any more after 389da25f93 "Yama:
add additional ptrace scopes".

security/yama/yama_lsm.c:322:12: warning: ‘one’ defined but not used
[-Wunused-variable]

security/yama/yama_lsm.c +0 -1
index afb04cb..c852f74 100644
@@ -319,7 +319,6 @@ static int yama_dointvec_minmax(struct ctl_table *table, int write,
 }
 
 static int zero;
-static int one = 1;
 static int max_scope = YAMA_SCOPE_NO_ATTACH;
 
 struct ctl_path yama_sysctl_path[] = {
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Dan Carpenter

GCC complains that we don't use "one" any more after 389da25f93 "Yama:
add additional ptrace scopes".

security/yama/yama_lsm.c:322:12: warning: ‘one’ defined but not used [-Wunused-variable]

Thanks for catching that! I was still building with another set of patches that used it. Whoops! :)

-Kees

Signature · 6 lines
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 7 lines · Kees Cook
Quoted 6 lines · Dan Carpenter

GCC complains that we don't use "one" any more after 389da25f93 "Yama:
add additional ptrace scopes".

security/yama/yama_lsm.c:322:12: warning: ?one? defined but not used [-Wunused-variable]

Quoted 6 lines
Quoted 1 line

Thanks for catching that! I was still building with another set of patches that used it. Whoops! :)

Thanks, applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next

- James

Signature · 2 lines
James Morris
<[email protected]>