x86: mrst: quiet sparse noise about plain integer as NULL pointer

PATCH In review H Hartley Sweeten 3 participants 4 messages Apr 24, 2012 – Apr 25, 2012 x86

lore

Share & tools

lore

H Hartley Sweeten

author

2012-04-24 22:01 UTC #0 lore raw

PATCH 1/1 x86: mrst: quiet sparse noise about plain integer as NULL pointer

The second parameter to intel_scu_notifier_post is a void * not an integer.

This quiets the sparse noise:

arch/x86/platform/mrst/mrst.c:808:48: warning: Using plain integer as NULL pointer arch/x86/platform/mrst/mrst.c:817:43: warning: Using plain integer as NULL pointer

Signed-off-by H Hartley Sweeten <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Ingo Molnar <[email protected]>

Cc "H. Peter Anvin" <[email protected]>

---

arch/x86/platform/mrst/mrst.c +2 -2

index e0a3723..e31bcd8 100644
@@ -805,7 +805,7 @@ void intel_scu_devices_create(void)
 		} else
 			i2c_register_board_info(i2c_bus[i], i2c_devs[i], 1);
 	}
-	intel_scu_notifier_post(SCU_AVAILABLE, 0L);
+	intel_scu_notifier_post(SCU_AVAILABLE, NULL);
 }
 EXPORT_SYMBOL_GPL(intel_scu_devices_create);

@@ -814,7 +814,7 @@ void intel_scu_devices_destroy(void)
 {
 	int i;
 
-	intel_scu_notifier_post(SCU_DOWN, 0L);
+	intel_scu_notifier_post(SCU_DOWN, NULL);
 
 	for (i = 0; i < ipc_next_dev; i++)
 		platform_device_del(ipc_devs[i]);

Alan Cox

Acked-by on v1 1/1

2012-04-25 10:25 UTC #1 lore raw

Quoted 6 lines

This quiets the sparse noise:
arch/x86/platform/mrst/mrst.c:808:48: warning: Using plain integer as NULL pointer arch/x86/platform/mrst/mrst.c:817:43: warning: Using plain integer as NULL pointer
Signed-off-by H Hartley Sweeten <[email protected]>

Acked-by Alan Cox <[email protected]>

Kirill A. Shutemov

Acked-by on v1 1/1

2012-04-25 10:57 UTC #2 lore raw

In reply to H Hartley Sweeten

Quoted 11 lines · H Hartley Sweeten

The second parameter to intel_scu_notifier_post is a void * not an integer.
This quiets the sparse noise:
arch/x86/platform/mrst/mrst.c:808:48: warning: Using plain integer as NULL pointer arch/x86/platform/mrst/mrst.c:817:43: warning: Using plain integer as NULL pointer
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>

Acked-by Kirill A. Shutemov <[email protected]>

Signature · 1 line

 Kirill A. Shutemov

tip-bot for H Hartley Sweeten

author

2012-04-25 13:56 UTC #3 lore raw

[tip:x86/urgent] x86/mrst: Quiet sparse noise about plain integer as NULL pointer

In reply to H Hartley Sweeten

Commit-ID:  d0d3bc65afcdd69bdd3b5bebdf8b3ee3680efa0e
Gitweb:     http://git.kernel.org/tip/d0d3bc65afcdd69bdd3b5bebdf8b3ee3680efa0e
Author:     H Hartley Sweeten <[email protected]>
AuthorDate: Tue, 24 Apr 2012 15:00:53 -0700
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 25 Apr 2012 12:47:08 +0200

x86/mrst: Quiet sparse noise about plain integer as NULL pointer

The second parameter to intel_scu_notifier_post is a void *, not an integer.

This quiets the sparse noise:

arch/x86/platform/mrst/mrst.c:808:48: warning: Using plain integer as NULL pointer arch/x86/platform/mrst/mrst.c:817:43: warning: Using plain integer as NULL pointer

Signed-off-by H Hartley Sweeten <[email protected]>

Acked-by Alan Cox <[email protected]>

Link http://lkml.kernel.org/r/[email protected] open here

Signed-off-by Ingo Molnar <[email protected]>

---
 arch/x86/platform/mrst/mrst.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

arch/x86/platform/mrst/mrst.c +2 -2

index e0a3723..e31bcd8 100644
@@ -805,7 +805,7 @@ void intel_scu_devices_create(void)
 		} else
 			i2c_register_board_info(i2c_bus[i], i2c_devs[i], 1);
 	}
-	intel_scu_notifier_post(SCU_AVAILABLE, 0L);
+	intel_scu_notifier_post(SCU_AVAILABLE, NULL);
 }
 EXPORT_SYMBOL_GPL(intel_scu_devices_create);

@@ -814,7 +814,7 @@ void intel_scu_devices_destroy(void)
 {
 	int i;
 
-	intel_scu_notifier_post(SCU_DOWN, 0L);
+	intel_scu_notifier_post(SCU_DOWN, NULL);
 
 	for (i = 0; i < ipc_next_dev; i++)
 		platform_device_del(ipc_devs[i]);