Skip to contentSkip to conversation

Asking for an old patch review

opkg-utils Apelete Seketeli 4 participants 5 messages Apr 25, 2012 – May 4, 2012

lore
Share & tools
lore
#0 lore raw

Hello,

I'm trying to get a patch for opkg-utils into oe-classic, and it seems some of the changes of my patch were already submitted to yocto a month ago:

https://lists.yoctoproject.org/pipermail/yocto/2012-March/007851.html

Since the opkg-utils recipe in oe-classic is using the yocto repository as SRC_URI, the patch mentioned in the link above should be applied to the yocto repository before I make further changes to opkg-utils.

Could someone here do a review of the above mentioned patch please ?

Best regards.

Signature · 1 line
        Apelete
#1 lore raw
Quoted 6 lines · Apelete Seketeli

Hello,

I'm trying to get a patch for opkg-utils into oe-classic, and it seems some of the changes of my patch were already submitted to yocto a month ago:

Quoted 8 lines

https://lists.yoctoproject.org/pipermail/yocto/2012-March/007851.html

Since the opkg-utils recipe in oe-classic is using the yocto repository as SRC_URI, the patch mentioned in the link above should be applied to the yocto repository before I make further changes to opkg-utils.

Could someone here do a review of the above mentioned patch please ?

FWIW: I'm using all those changes squashed together
http://git.openembedded.org/openembedded-core-contrib/commit/?h=shr&id=b355502a48371cd7fb676eb01cf15c9b9c941352

and when that patchset get applied upstream we'll just change SRCREV and drop shr.patch..

feel free to do it that way in oe-classic too, if it's not applied soon..

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
In reply to Apelete Seketeli

Any updates on this?

Apelete Seketeli skrev 2012-04-25 23:47:

Quoted 16 lines

Hello,

I'm trying to get a patch for opkg-utils into oe-classic, and it seems some of the changes of my patch were already submitted to yocto a month ago:

https://lists.yoctoproject.org/pipermail/yocto/2012-March/007851.html

Since the opkg-utils recipe in oe-classic is using the yocto repository as SRC_URI, the patch mentioned in the link above should be applied to the yocto repository before I make further changes to opkg-utils.

Could someone here do a review of the above mentioned patch please ?

Best regards.

#3 lore raw
Quoted 18 lines · Kristoffer Eriksson

Any updates on this?

Apelete Seketeli skrev 2012-04-25 23:47:

Quoted 15 lines

Hello,

I'm trying to get a patch for opkg-utils into oe-classic, and it seems some of the changes of my patch were already submitted to yocto a month ago:

https://lists.yoctoproject.org/pipermail/yocto/2012-March/007851.html

Since the opkg-utils recipe in oe-classic is using the yocto repository as SRC_URI, the patch mentioned in the link above should be applied to the yocto repository before I make further changes to opkg-utils.

Could someone here do a review of the above mentioned patch please ?

Have you checked the opkg-utils git repo? It seems they have been merged.

Sau!

Quoted 8 lines
Quoted 1 line

Best regards.

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#4 lore raw
Quoted 12 lines · Saul Wold
Quoted 11 lines · Kristoffer Eriksson

Any updates on this?

Apelete Seketeli skrev 2012-04-25 23:47:

Quoted 8 lines

Hello,

I'm trying to get a patch for opkg-utils into oe-classic, and it seems some of the changes of my patch were already submitted to yocto a month ago:

https://lists.yoctoproject.org/pipermail/yocto/2012-March/007851.html

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

Since the opkg-utils recipe in oe-classic is using the yocto repository as SRC_URI, the patch mentioned in the link above should be applied to the yocto repository before I make further changes to opkg-utils.

Could someone here do a review of the above mentioned patch please ?

Have you checked the opkg-utils git repo? It seems they have been merged.

I'm aware they have been merged indeed, on April 26th, by Richard Purdie precisely.
Thanks for the work.

Cheers.

Signature · 1 line
        Apelete