Skip to contentSkip to conversation

tty: mxser: local variables should not be exposed globally

PATCH In review H Hartley Sweeten 2 participants 2 messages May 3, 2012

Subsystems (3)
Arm i.MX and Layerscape TTY layer and serial drivers Moxa smartio/industio/intellio serial card
lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 tty: mxser: local variables should not be exposed globally

The variable 'mxser_port_ops' is only referenced in this file and should be marked static to prevent it from being exposed globally.

Quites the sparse warning:

warning: symbol 'mxser_port_ops' was not declared. Should it be static?

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Jiri Slaby <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

---

drivers/tty/mxser.c +1 -1
index c6f372d..90cc680 100644
@@ -2326,7 +2326,7 @@ static const struct tty_operations mxser_ops = {
 	.get_icount = mxser_get_icount,
 };
 
-struct tty_port_operations mxser_port_ops = {
+static struct tty_port_operations mxser_port_ops = {
 	.carrier_raised = mxser_carrier_raised,
 	.dtr_rts = mxser_dtr_rts,
 	.activate = mxser_activate,
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · On Wed, 2 May 2012 17:57:17 -0700 H Hartley Sweeten…

The variable 'mxser_port_ops' is only referenced in this file and should be marked static to prevent it from being exposed globally.

Acked-by Alan Cox <[email protected]>