Skip to contentSkip to conversation

mtd-utils: Better document --pagesize of mkfs.jffs2

PATCH Applied Shmulik Ladkani 2 participants 2 messages May 3, 2012 – May 4, 2012 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd-utils: Better document --pagesize of mkfs.jffs2

Add a strict explanation '--pagesize' refers to target system's mm page size.

---

This is according to the below discussion:
http://lists.infradead.org/pipermail/linux-mtd/2012-May/041233.html

mkfs.jffs2.1 +2 -1
index 9b0acc3..47a3ac7 100644
@@ -137,7 +137,8 @@ directory.
 .TP
 .B -s, --pagesize=SIZE
 Use page size SIZE.  The default is 4 KiB.  This size is the
-maximum size of a data node.
+maximum size of a data node.  Set according to target system's memory
+management page size (NOTE: this is NOT related to NAND page size).
 .TP
 .B -e, --eraseblock=SIZE
 Use erase block size SIZE.  The default is 64 KiB.  If you use a erase
mkfs.jffs2.c +3 -1
index ad88ac6..d170a04 100644
@@ -1391,7 +1391,9 @@ static const char helptext[] =
 "                          not specified, the output is padded to the end of\n"
 "                          the final erase block\n"
 "  -r, -d, --root=DIR      Build file system from directory DIR (default: cwd)\n"
-"  -s, --pagesize=SIZE     Use page size (max data node size) SIZE (default: 4KiB)\n"
+"  -s, --pagesize=SIZE     Use page size (max data node size) SIZE.\n"
+"                          Set according to target system's memory management\n"
+"                          page size (default: 4KiB)\n"
 "  -e, --eraseblock=SIZE   Use erase block size SIZE (default: 64KiB)\n"
 "  -c, --cleanmarker=SIZE  Size of cleanmarker (default 12)\n"
 "  -m, --compr-mode=MODE   Select compression mode (default: priortiry)\n"