Skip to contentSkip to conversation

x86/efi changes for v3.5

GIT PULL Ingo Molnar 4 participants 4 messages May 23, 2012 – Jun 3, 2012 x86

lore
Share & tools
lore

Ingo Molnar

author
#0 lore raw

Linus,

Please pull the latest x86-efi-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-efi-for-linus

HEAD: a9aff3eaaf0966c2a1bb3717d811363d81e52c76 Merge branch x86/build into x86/efi and fix up arch/x86/boot/tools/build.c

(This is the tree hpa sent two weeks ago.)

This patchset makes changes to the bzImage EFI header, so that it can be signed with a secure boot signature tool. It should not affect anyone who is not using the EFI self-boot feature in any way.

Thanks,

Ingo

----------------->

H. Peter Anvin (1):
Merge branch x86/build into x86/efi and fix up arch/x86/boot/tools/build.c

Jordan Justen (1):
x86, efi: Fix issue of overlapping .reloc section for EFI_STUB

Matt Fleming (2):
x86, efi: Fix .text section overlapping image header for EFI_STUB x86, efi: Fix NumberOfRvaAndSizes field in PE32 header for EFI_STUB

 arch/x86/boot/compressed/eboot.c |   14 +++++++++++---
 arch/x86/boot/header.S           |   26 +++++++++-----------------
 arch/x86/boot/tools/build.c      |   24 +++++++++++++++++++++---
 3 files changed, 41 insertions(+), 23 deletions(-)
arch/x86/boot/compressed/eboot.c +11 -3
index fec216f..01cbb87 100644
@@ -904,11 +904,19 @@ struct boot_params *efi_main(void *handle, efi_system_table_t *_table)
 
 	memset(boot_params, 0x0, 0x4000);
 
-	/* Copy first two sectors to boot_params */
-	memcpy(boot_params, image->image_base, 1024);
-
 	hdr = &boot_params->hdr;
 
+	/* Copy the second sector to boot_params */
+	memcpy(&hdr->jump, image->image_base + 512, 512);
+
+	/*
+	 * Fill out some of the header fields ourselves because the
+	 * EFI firmware loader doesn't load the first sector.
+	 */
+	hdr->root_flags = 1;
+	hdr->vid_mode = 0xffff;
+	hdr->boot_flag = 0xAA55;
+
 	/*
 	 * The EFI firmware loader could have placed the kernel image
 	 * anywhere in memory, but the kernel has various restrictions
arch/x86/boot/header.S +9 -17
index f1bbeeb..8bbea6a 100644
@@ -147,7 +147,7 @@ optional_header:
 	# Filled in by build.c
 	.long	0x0000				# AddressOfEntryPoint
 
-	.long	0x0000				# BaseOfCode
+	.long	0x0200				# BaseOfCode
 #ifdef CONFIG_X86_32
 	.long	0				# data
 #endif

@@ -189,7 +189,7 @@ extra_header_fields:
 	.quad	0				# SizeOfHeapCommit
 #endif
 	.long	0				# LoaderFlags
-	.long	0x1				# NumberOfRvaAndSizes
+	.long	0x6				# NumberOfRvaAndSizes
 
 	.quad	0				# ExportTable
 	.quad	0				# ImportTable

@@ -217,18 +217,17 @@ section_table:
 
 	#
 	# The EFI application loader requires a relocation section
-	# because EFI applications are relocatable and not having
-	# this section seems to confuse it. But since we don't need
-	# the loader to fixup any relocs for us just fill it with a
-	# single dummy reloc.
+	# because EFI applications must be relocatable. But since
+	# we don't need the loader to fixup any relocs for us, we
+	# just create an empty (zero-length) .reloc section header.
 	#
 	.ascii	".reloc"
 	.byte	0
 	.byte	0
-	.long	reloc_end - reloc_start
-	.long	reloc_start
-	.long	reloc_end - reloc_start		# SizeOfRawData
-	.long	reloc_start			# PointerToRawData
+	.long	0
+	.long	0
+	.long	0				# SizeOfRawData
+	.long	0				# PointerToRawData
 	.long	0				# PointerToRelocations
 	.long	0				# PointerToLineNumbers
 	.word	0				# NumberOfRelocations

@@ -469,10 +468,3 @@ setup_corrupt:
 
 	.data
 dummy:	.long	0
-
-	.section .reloc
-reloc_start:
-	.long	dummy - reloc_start
-	.long	10
-	.word	0
-reloc_end:
arch/x86/boot/tools/build.c +21 -3
index ed54976..4596388 100644
@@ -198,12 +198,19 @@ int main(int argc, char ** argv)
 
 	pe_header = get_unaligned_le32(&buf[0x3c]);
 
-	/* Size of code */
-	put_unaligned_le32(file_sz, &buf[pe_header + 0x1c]);
-
 	/* Size of image */
 	put_unaligned_le32(file_sz, &buf[pe_header + 0x50]);
 
+	/*
+	 * Subtract the size of the first section (512 bytes) which
+	 * includes the header and .reloc section. The remaining size
+	 * is that of the .text section.
+	 */
+	file_sz -= 512;
+
+	/* Size of code */
+	put_unaligned_le32(file_sz, &buf[pe_header + 0x1c]);
+
 #ifdef CONFIG_X86_32
 	/* Address of entry point */
 	put_unaligned_le32(i, &buf[pe_header + 0x28]);

@@ -211,8 +218,14 @@ int main(int argc, char ** argv)
 	/* .text size */
 	put_unaligned_le32(file_sz, &buf[pe_header + 0xb0]);
 
+	/* .text vma */
+	put_unaligned_le32(0x200, &buf[pe_header + 0xb4]);
+
 	/* .text size of initialised data */
 	put_unaligned_le32(file_sz, &buf[pe_header + 0xb8]);
+
+	/* .text file offset */
+	put_unaligned_le32(0x200, &buf[pe_header + 0xbc]);
 #else
 	/*
 	 * Address of entry point. startup_32 is at the beginning and

@@ -224,9 +237,14 @@ int main(int argc, char ** argv)
 	/* .text size */
 	put_unaligned_le32(file_sz, &buf[pe_header + 0xc0]);
 
+	/* .text vma */
+	put_unaligned_le32(0x200, &buf[pe_header + 0xc4]);
+
 	/* .text size of initialised data */
 	put_unaligned_le32(file_sz, &buf[pe_header + 0xc8]);
 
+	/* .text file offset */
+	put_unaligned_le32(0x200, &buf[pe_header + 0xcc]);
 #endif /* CONFIG_X86_32 */
 #endif /* CONFIG_EFI_STUB */
#1 lore raw

Hi Ingo, Hans Peter, Matt, Jordan,

Quoted 4 lines

This patchset makes changes to the bzImage EFI header, so that it can be signed with a secure boot signature tool. It should not affect anyone who is not using the EFI self-boot feature in any way.

Commit 2e064b1 (Fix issue of overlapping .reloc section for EFI_STUB) breaks EFI boot on my MacBookAir3,1. The efi firmware no longer recognizes the bzImage and falls back to BIOS emulation boot.

Reverting 2e064b1 works for me, but I am happy to test other options as well.

Thanks,
Henrik

reviewer
#2 lore raw
Quoted 7 lines · Henrik Rydberg

Hi Ingo, Hans Peter, Matt, Jordan,

Quoted 4 lines

This patchset makes changes to the bzImage EFI header, so that it can be signed with a secure boot signature tool. It should not affect anyone who is not using the EFI self-boot feature in any way.

Quoted 7 lines

Commit 2e064b1 (Fix issue of overlapping .reloc section for EFI_STUB) breaks EFI boot on my MacBookAir3,1. The efi firmware no longer recognizes the bzImage and falls back to BIOS emulation boot.

Reverting 2e064b1 works for me, but I am happy to test other options as well.

Matt, Jordan,

Could you look into this please?

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
#3 lore raw
Quoted 12 lines · H. Peter Anvin
Quoted 11 lines · Henrik Rydberg

Hi Ingo, Hans Peter, Matt, Jordan,

Quoted 4 lines

This patchset makes changes to the bzImage EFI header, so that it can be signed with a secure boot signature tool. It should not affect anyone who is not using the EFI self-boot feature in any way.

Commit 2e064b1 (Fix issue of overlapping .reloc section for EFI_STUB) breaks EFI boot on my MacBookAir3,1. The efi firmware no longer recognizes the bzImage and falls back to BIOS emulation boot.

Quoted 7 lines
Quoted 3 lines

Reverting 2e064b1 works for me, but I am happy to test other options as well.

Matt, Jordan,

Could you look into this please?

Yeah, there's a bug report for this here,

	https://bugzilla.kernel.org/show_bug.cgi?id=43309

I suspect that older firmware doesn't handle a zero .reloc section properly. So, unfortunately we will have to leave the .reloc section with a dummy reloc, rather than having one with no entries.

I'll put a patch together.